Android WebView CTS L/M bot failing many of tests |
|||
Issue descriptionBoth bots started fail multiple tests, and went back to green for 2 runs and are now failing again https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/17974 https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/16180 They are reproducible locally and if I just open system webview shell, it will crash with the following message: D/cr_BuildInfo(23349): [BuildInfo.java:74] GMS package is not found: android.content.pm.PackageManager$NameNotFoundException: com.google.android.gms D/cr_BuildInfo(23349): android.content.pm.PackageManager$NameNotFoundException: com.google.android.gms D/cr_BuildInfo(23349): at android.app.ApplicationPackageManager.getPackageInfo(ApplicationPackageManager.java:114) D/cr_BuildInfo(23349): at org.chromium.base.BuildInfo.getGMSVersionCode(BuildInfo.java:71) D/cr_BuildInfo(23349): at org.chromium.content.browser.BrowserStartupController.nativeSetCommandLineFlags(Native Method) D/cr_BuildInfo(23349): at org.chromium.content.browser.BrowserStartupController.access$700(BrowserStartupController.java:40) D/cr_BuildInfo(23349): at org.chromium.content.browser.BrowserStartupController$4.run(BrowserStartupController.java:316) D/cr_BuildInfo(23349): at org.chromium.content.browser.BrowserStartupController.prepareToStartBrowserProcess(BrowserStartupController.java:329) D/cr_BuildInfo(23349): at org.chromium.content.browser.BrowserStartupController.startBrowserProcessesSync(BrowserStartupController.java:211) D/cr_BuildInfo(23349): at org.chromium.android_webview.AwBrowserProcess$1.run(AwBrowserProcess.java:103) D/cr_BuildInfo(23349): at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:67) D/cr_BuildInfo(23349): at org.chromium.android_webview.AwBrowserProcess.start(AwBrowserProcess.java:81) D/cr_BuildInfo(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.startChromiumLocked(WebViewChromiumFactoryProvider.java:405) D/cr_BuildInfo(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.ensureChromiumStartedLocked(WebViewChromiumFactoryProvider.java:347) D/cr_BuildInfo(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.getStatics(WebViewChromiumFactoryProvider.java:486) D/cr_BuildInfo(23349): at android.webkit.WebView.setWebContentsDebuggingEnabled(WebView.java:1815) D/cr_BuildInfo(23349): at org.chromium.webview_shell.WebViewBrowserActivity.onCreate(WebViewBrowserActivity.java:169) D/cr_BuildInfo(23349): at android.app.Activity.performCreate(Activity.java:5990) D/cr_BuildInfo(23349): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1106) D/cr_BuildInfo(23349): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2278) D/cr_BuildInfo(23349): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2387) D/cr_BuildInfo(23349): at android.app.ActivityThread.access$800(ActivityThread.java:151) D/cr_BuildInfo(23349): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303) D/cr_BuildInfo(23349): at android.os.Handler.dispatchMessage(Handler.java:102) D/cr_BuildInfo(23349): at android.os.Looper.loop(Looper.java:135) D/cr_BuildInfo(23349): at android.app.ActivityThread.main(ActivityThread.java:5254) D/cr_BuildInfo(23349): at java.lang.reflect.Method.invoke(Native Method) D/cr_BuildInfo(23349): at java.lang.reflect.Method.invoke(Method.java:372) D/cr_BuildInfo(23349): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) D/cr_BuildInfo(23349): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) I/Adreno (23349): EGLInit: QTI Build: 01/29/15, 1bccc5d, I0ba6dce82d D/AndroidRuntime(23349): Shutting down VM E/AndroidRuntime(23349): FATAL EXCEPTION: main E/AndroidRuntime(23349): Process: org.chromium.webview_shell, PID: 23349 E/AndroidRuntime(23349): java.lang.AssertionError E/AndroidRuntime(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.getBrowserContextOnUiThread(WebViewChromiumFactoryProvider.java:446) E/AndroidRuntime(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.startChromiumLocked(WebViewChromiumFactoryProvider.java:421) E/AndroidRuntime(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.ensureChromiumStartedLocked(WebViewChromiumFactoryProvider.java:347) E/AndroidRuntime(23349): at com.android.webview.chromium.WebViewChromiumFactoryProvider.getStatics(WebViewChromiumFactoryProvider.java:486) E/AndroidRuntime(23349): at android.webkit.WebView.setWebContentsDebuggingEnabled(WebView.java:1815) E/AndroidRuntime(23349): at org.chromium.webview_shell.WebViewBrowserActivity.onCreate(WebViewBrowserActivity.java:169) E/AndroidRuntime(23349): at android.app.Activity.performCreate(Activity.java:5990) E/AndroidRuntime(23349): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1106) E/AndroidRuntime(23349): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2278) E/AndroidRuntime(23349): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2387) E/AndroidRuntime(23349): at android.app.ActivityThread.access$800(ActivityThread.java:151) E/AndroidRuntime(23349): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303) E/AndroidRuntime(23349): at android.os.Handler.dispatchMessage(Handler.java:102) E/AndroidRuntime(23349): at android.os.Looper.loop(Looper.java:135) E/AndroidRuntime(23349): at android.app.ActivityThread.main(ActivityThread.java:5254) E/AndroidRuntime(23349): at java.lang.reflect.Method.invoke(Native Method) E/AndroidRuntime(23349): at java.lang.reflect.Method.invoke(Method.java:372) E/AndroidRuntime(23349): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) E/AndroidRuntime(23349): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) W/ActivityManager( 817): Force finishing activity 1 org.chromium.webview_shell/.WebViewBrowserActivity
,
Nov 17 2016
that seems close, if it is the reason, let's revert at once please.
,
Nov 17 2016
Just reverted it
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca commit 5e5387276fc07873f2a2c730b7b1adbd0d0a70ca Author: yolandyan <yolandyan@chromium.org> Date: Thu Nov 17 06:54:34 2016 Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #2 id:140001 of https://codereview.chromium.org/2506013004/ ) Reason for revert: This CL cause WebView to crash BUG= 666193 Original issue's description: > Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. > > Reverted in: > https://codereview.chromium.org/2507153002/ > > Reason for reland: > Now explicitly lists default toolchain > > Also modify java_assertion_enabler to resolve cycle dependency issue > and empty jar issue. > > TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org > BUG= 462676 ,665157,665478 > > Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e > Cr-Commit-Position: refs/heads/master@{#432607} TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org,zpeng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 462676 ,665157,665478 Review-Url: https://codereview.chromium.org/2506263003 Cr-Commit-Position: refs/heads/master@{#432789} [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/BUILD.gn [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/build/android/java_assertion_enabler/BUILD.gn [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/build/config/android/internal_rules.gni [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java [modify] https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca/third_party/ow2_asm/BUILD.gn
,
Nov 17 2016
Is this just one specific assertion that we're violating and have just never previously noticed because WebView only runs on L+ and assert has always been a no-op on L+, or is this a problem with the mechanism of enabling it?
,
Nov 17 2016
It's just that an assert is now failing (the one listed above here: WebViewChromiumFactoryProvider.java:446). I'll help Felix run this test locally and make sure disabling that assert doesn't trigger any others.
,
Nov 17 2016
Yeah that assert is either just wrong or is actually backwards. :)
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a360e5ed7d790433b0be74169afa7643324d0d commit 00a360e5ed7d790433b0be74169afa7643324d0d Author: zpeng <zpeng@chromium.org> Date: Mon Nov 21 23:05:02 2016 Reland #2 of Add GN build rules to allow java_assertion_enabler to enable Java asserts. Reverted by: https://codereview.chromium.org/2506263003/ Reason for reland: Fixed failing tests. TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org,yolandyan@chromium.org BUG= 666193 , 667337 , 462676 ,665157,665478,667437 Review-Url: https://codereview.chromium.org/2517203002 Cr-Commit-Position: refs/heads/master@{#433681} [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/BUILD.gn [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/build/android/java_assertion_enabler/BUILD.gn [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/build/config/android/internal_rules.gni [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java [modify] https://crrev.com/00a360e5ed7d790433b0be74169afa7643324d0d/third_party/ow2_asm/BUILD.gn
,
Nov 28 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, Nov 17 2016Labels: -Pri-2 OS-Android Pri-1
Owner: zpeng@chromium.org