Issue metadata
Sign in to add a comment
|
Regression: Focus doesn't traverse to apps icon on hitting F6 |
||||||||||||||||||||||
Issue descriptionVersion: 56.0.2922.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and Open any page >> Make sure bookmark bar is attached >> Hit F6 to focus Omibox (2)Now again hit F6 so that focus should traverse to apps icon on bookmark bar Expected: Focus should move to Apps shortcut on bookmark bar after hitting F6 twice. Actual: Instead focus is seen missing. This is a regression issue broken in M56. Will provide bisect info soon.
,
Nov 17 2016
Scenario doesn't hold on Mac, Issue is reproducible on 56.0.2922.0 of Linux Ubuntu 14.04.
,
Nov 17 2016
Duplicating with issue 664776 .
,
Nov 17 2016
Manual Bisect Info: ==================== Good Build : 56.0.2913.0 Bad Build : 56.0.2914.0
,
Nov 17 2016
Narrow Bisect:: =============== Good :56.0.2913.0 -- (build revision 430459) Bad:: 56.0.2914.0 -- (build revision 430837) ChangeLog: ================ https://chromium.googlesource.com/chromium/src/+log/a4682914fc8311ff96c6b4f2a4ee890f36c56e97..ca8b19cd01cfb691bfa31e4605f4204dd8da8aab possible suspect ================== ca8b19cd01cfb691bfa31e4605f4204dd8da8aab Review URL: https://codereview.chromium.org/2447523002 bruthig@ could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue. Thanks.
,
Nov 17 2016
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a57939b6193ccb89fc70aa624a6f29140efac422 commit a57939b6193ccb89fc70aa624a6f29140efac422 Author: bruthig <bruthig@chromium.org> Date: Thu Nov 17 22:28:44 2016 Enabled ink drop highlight for focus on bookmark bar buttons. This is fixing a regression caused by https://codereview.chromium.org/2447523002. BUG= 666192 Review-Url: https://codereview.chromium.org/2508243002 Cr-Commit-Position: refs/heads/master@{#432994} [modify] https://crrev.com/a57939b6193ccb89fc70aa624a6f29140efac422/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Nov 21 2016
Issue 664776 has been merged into this issue.
,
Nov 21 2016
,
Nov 21 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 21 2016
No merge is required as the fix landed before branch.
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kochi@chromium.org
, Nov 17 2016