New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666183 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Options like writing direction and paste are missing from context menu in chrome://md-settings page.

Reported by mni...@etouch.net, Nov 17 2016

Issue description

Version: 56.0.2922.0 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511} (64-bit)
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings and right click in search settings search box and observe context menu options

Actual: Options like writing direction and paste are missing from context menu
Expected: Options like writing direction and paste should be present

This is regression issue, broken in ‘M 56’ and will soon update other info :
Good build:56.0.2920.0 
Bad build: 56.0.2922.0
 
 
Actual_screenshot.png
294 KB View Download
Expected_screenshot.png
287 KB View Download

Comment 1 by mni...@etouch.net, Nov 17 2016

Labels: OS-Linux
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2920.0 (Revision: 432057).
Bad build: 56.0.2992.0 (Revision: 432511).

You are probably looking for a change made after 432277 (known good), but no later than 432278 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/5ce3e1f8fef0f96ae28a09ac0aba2dc49802f9ee..aaffafea03c011414d72d7997bdd83d2f4853de0

@tsergeant -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/572f871f139ed9a514b69707a7e25345fff0de2b

commit 572f871f139ed9a514b69707a7e25345fff0de2b
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Nov 18 04:37:18 2016

MD WebUI: Fix minor rendering problems in <cr-toolbar>

In crrev.com/589355, the <cr-toolbar> element moved from using
paper-input to a native <input> element. This CL fixes two minor issues
that came about as a result of this change:

* Fix font rendering issues on macOS so that text is the right size and
  antialiased correctly
* Ensure that right clicking shows the <input> context menu
* Prevent label text from wrapping during animations

BUG= 589355 , 666183 , 666180 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2502413003
Cr-Commit-Position: refs/heads/master@{#433107}

[modify] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Status: Fixed (was: Started)
Labels: Merge-Request-56
Verified in Canary, requesting merge back to M56.

Comment 7 by dimu@chromium.org, Nov 20 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 20 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8832b0411ba993c9a62ff52044767a5885d758ab

commit 8832b0411ba993c9a62ff52044767a5885d758ab
Author: Tim Sergeant <tsergeant@chromium.org>
Date: Sun Nov 20 23:23:55 2016

MD WebUI: Fix minor rendering problems in <cr-toolbar>

In crrev.com/589355, the <cr-toolbar> element moved from using
paper-input to a native <input> element. This CL fixes two minor issues
that came about as a result of this change:

* Fix font rendering issues on macOS so that text is the right size and
  antialiased correctly
* Ensure that right clicking shows the <input> context menu
* Prevent label text from wrapping during animations

BUG= 589355 , 666183 , 666180 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2502413003
Cr-Commit-Position: refs/heads/master@{#433107}
(cherry picked from commit 572f871f139ed9a514b69707a7e25345fff0de2b)

Review URL: https://codereview.chromium.org/2520623004 .

Cr-Commit-Position: refs/branch-heads/2924@{#15}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/8832b0411ba993c9a62ff52044767a5885d758ab/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/8832b0411ba993c9a62ff52044767a5885d758ab/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/8832b0411ba993c9a62ff52044767a5885d758ab/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Sign in to add a comment