'Alt+LeftArrow' and 'Alt+RightArrow' should not be handled by <select>
Reported by
dmascare...@etouch.net,
Nov 17 2016
|
||||||
Issue descriptionChrome Version:56.0.2922.0 (Official Build) 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511} OS: Windows (7,8,10),Mac(10.11.6,10.12.1) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/ 2. Click on 'Import bookmarks and settings' and try to hit 'Alt+Forward' (i.e. 'Alt+->'),Observe. 3. Press 'Alt+Back' (i.e. 'Alt+ <-'),Observe. Actual:1. After step 2, dropdown list option gets selected. 2. After step 3, Dialogbox does not close (i.e. page does not back navigate to Main page) Expected:1. After step 2, dropdown list option should not get selected.(Comparing behavior with 'Clear browsing data') 2. After step 3, Dialogbox should get closed(i.e. page should navigate back to Main page) This is non-regression issue, seen from 'M 56' (56.0.2921.0) newly added feature.
,
Nov 17 2016
Note: Above issue is seen on Linux OS.
,
Nov 17 2016
@dmascarenhas: URL for this dialog was implemented at https://crrev.com/de32677904b9842102af5c93b9ea5db119b3c5f4, which corresponds to #432903. Your test case is on #432511, which is earlier. @tommycli: Can you verify if alt-back, alt-forward work as expected? From a quick test I did, alt-forward does, but alt-back does not close the dialog and go back to chrome://md-settings.
,
Nov 17 2016
It appears that the Browser Profile select field is eating up the arrow button key events...
,
Nov 17 2016
Per offline discussion, we could fix <select> to not handle left/right arrow when "alt" modifier is pressed. Looking at the code at [1] there is currently no such check. Updating title to reflect that. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp?l=1298,1296
,
Nov 17 2016
Here is a minimal example, https://jsfiddle.net/papfwcnb/2/. It seems that Firefox is handling this correctly (alt+left, alt+right trigger navigation, even when select is focused).
,
Nov 17 2016
,
Nov 18 2016
this IS not happening for me on Mac stable nor canary. it IS reproducing on Windows (alt + left/right in the fiddle is the same as left/right) it WAS happening for me on Linux earlier.
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82e245731a18bee4a64ba37e3cd4aeace09c8274 commit 82e245731a18bee4a64ba37e3cd4aeace09c8274 Author: dbeam <dbeam@chromium.org> Date: Mon Nov 21 18:20:56 2016 <select>: ignore modified keydown events in some cases For example, don't mark Alt + left/right handled so that back/forward continue to work when a <select> is focused. R=tkent@chromium.org BUG= 666179 Review-Url: https://codereview.chromium.org/2511923002 Cr-Commit-Position: refs/heads/master@{#433589} [add] https://crrev.com/82e245731a18bee4a64ba37e3cd4aeace09c8274/third_party/WebKit/LayoutTests/fast/forms/select/ignore-keydown-with-modifiers.html [modify] https://crrev.com/82e245731a18bee4a64ba37e3cd4aeace09c8274/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
,
Nov 21 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Nov 17 2016Status: Untriaged (was: Unconfirmed)