New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666176 link

Starred by 0 users
Status: Fixed
Owner:
█ lpz@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Spacing issue is observed between two checkboxes of 'chrome://md-settings/privacy'

Reported by dmascare...@etouch.net, Nov 17 2016 
Chrome Version:56.0.2922.0 (Official Build) 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511}
OS: Windows (7,8,10),Mac(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/privacy
2. Observe space between two checkbox under privacy section.

Actual:  Spacing issue is observed between two check boxes.
Expected: Spacing issue should not be seen.

This is regression issue, broken in 'M 56' and below is manual bisect info:

Good build:56.0.2920.0
Bad build:56.0.2922.0
Actual_privacy.png
54.0 KB View Download

Comment 1 by msrchandra@chromium.org, Nov 17 2016

Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: lpz@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2920.0 (Revision: 432057).
Bad build: 56.0.2992.0 (Revision: 432511).

You are probably looking for a change made after 432288 (known good), but no later than 432289 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/11a42166b7ca5f2ac4ff371110d41054a2d1dc3e..36d8239faf3212845af4c08c4836a637a48cd234

@lpz -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Issue is also observed on Linux.
Thank You.

Comment 2 by lpz@chromium.org, Nov 17 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f3740f5dc6c9f858523f8a2fdb92a0b8d980ee8

commit 1f3740f5dc6c9f858523f8a2fdb92a0b8d980ee8
Author: lpz <lpz@chromium.org>
Date: Thu Nov 17 23:11:34 2016

Fix vertical spacing of extended reporting checkbox.

This was broken by my recent change to change this checkbox from a settings-checkbox to a paper-checkbox (but forgot to include the style config).

BUG= 666176 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2508183002
Cr-Commit-Position: refs/heads/master@{#433007}

[modify] https://crrev.com/1f3740f5dc6c9f858523f8a2fdb92a0b8d980ee8/chrome/browser/resources/settings/privacy_page/privacy_page.html

Comment 4 by lpz@chromium.org, Nov 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment