Prevent in-page navigations from stopping the app banner pipeline |
|||||
Issue descriptionTriggering a fragment navigation or history.pushState action whilst the app banner pipeline is checking a page's eligibility will stop the pipeline. This can cause racey behaviour with banners. We should ignore these in-page navigations.
,
Nov 18 2016
Requesting merge of #1 to M55. This has baked in Canary and I've verified the change manually.
,
Nov 18 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65fc2a2547f3ce03aedf8bedbbec685029a76c2c commit 65fc2a2547f3ce03aedf8bedbbec685029a76c2c Author: Dominick Ng <dominickn@chromium.org> Date: Fri Nov 18 18:59:02 2016 Prevent in-page navigations from stopping the app banner pipeline. Triggering a fragment navigation or history.pushState action whilst the app banner pipeline is checking a page's eligibility will prevent the banner from being shown even if the page is eligible. This is because any main frame navigation currently stops the checking pipeline to prevent the banner from being shown after a navigation. This CL addresses the issue by ignoring in-page navigations when the banner pipeline is active. BUG= 666165 Review-Url: https://codereview.chromium.org/2507163003 Cr-Commit-Position: refs/heads/master@{#432778} (cherry picked from commit 803300091bf7d275a9456b0362e3a9ddb9f61abb) Review URL: https://codereview.chromium.org/2515793002 . Cr-Commit-Position: refs/branch-heads/2883@{#613} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/65fc2a2547f3ce03aedf8bedbbec685029a76c2c/chrome/browser/banners/app_banner_manager.cc
,
Nov 18 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Nov 17 2016