New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666164 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[MD settings] code cleanup - fake prefs

Project Member Reported by dschuyler@chromium.org, Nov 17 2016

Issue description

This is a todo reminder for some code cleanup.

In the chrome://md-settings we have controls and policy indicators that interface with prefs objects. In some cases a pref object is not readily available for use with the control or indicator, so a fake-pref is fabricated to glue the pieces together. Better ways to handle this would be to decompose the controls and indicators so that they can work with or without a pref object; Or, by creating pref objects for those systems/settings that don't currently operate on prefs objects
 
Summary: [MD settings] code cleanup - fake prefs (was: [MD settings] policy/controlled by and settings controls)

Comment 2 by dbeam@chromium.org, Nov 21 2016

Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dbeam@chromium.org, Jan 6 2017

Labels: Hotlist-MD-Settings-Privacy-SiteSettings
Cc: scottchen@chromium.org steve...@chromium.org
Status: WontFix (was: Assigned)
We had many off-line discussions on this topic. I've become convinced that the essential pieces of a 'fake pref' is truly needed by controls. Maybe the 'pref' info for controls should simply be renamed to 'controlInfo' or similar. i.e. the data isn't wrong, but the member name is.

Sign in to add a comment