Some views::Label selection related tests are flaky on Mac. |
||
Issue descriptionVersion: 56.0.2919.0 OS: Mac Some selections related tests for views::Labels are flaky on Mac, eg: -LabelSelectionTest.FocusOnClick -LabelSelectionTest.FocusTraversal -LabelSelectionTest.Selectable See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=views_unittests&builder=chromium.mac%3AMac10.11%20Tests. These were added in https://codereview.chromium.org/2486963003/.
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50221c896a243c90466c5bed3ad83008198ea2b5 commit 50221c896a243c90466c5bed3ad83008198ea2b5 Author: karandeepb <karandeepb@chromium.org> Date: Fri Nov 18 05:41:03 2016 MacViews: Fix flaky label selection tests. r431107 enabled text selection related tests on Mac by using RenderTextHarfBuzz for these tests. It did this by appending the kEnableHarfBuzzRenderText switch to the list of command line switches. However RenderText::CreateInstance() assigns the result of evaluating the presence of this switch to the static variable |use_native|. As a result, if another test has already initialized the variable |use_native| to true, appending the kEnableHarfBuzzRenderText switch has no effect. This causes the Label selection tests to fail on Mac. To fix, make the |use_native| variable non-static. BUG= 666162 Review-Url: https://codereview.chromium.org/2507363003 Cr-Commit-Position: refs/heads/master@{#433123} [modify] https://crrev.com/50221c896a243c90466c5bed3ad83008198ea2b5/ui/gfx/render_text.cc
,
Nov 29 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by karandeepb@chromium.org
, Nov 17 2016