New issue
Advanced search Search tips

Issue 666159 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Trim/inspect the size of CT-related symbols

Project Member Reported by eranm@chromium.org, Nov 17 2016

Issue description

According to mef@ in https://bugs.chromium.org/p/chromium/issues/detail?id=663883, not having CT-related symbols linked in decreases the binary size by ~50K.

This is considered a large size for CT code, we should:
(!) look into trimming the code.
(2) enabling more linker optimizations for this code (for example, net::ct::HashAlgorithmToString shouldn't be linked in unless the SCT information is to be printed to somewhere).
 
mef: Could you provide pointers to instructions on how to build optimized cronet builds with symbols? You mentioned cronet.Framework - was this a macOS build? An iOS build? Are there different directions for Android builds/Linux builds?

This will help trace-through the costs to make sure everything is consistent.

Comment 2 by mef@chromium.org, Nov 17 2016

I've only tried it with cronet builds for iOS. 
Those builds require chromium checkout on Mac OS.

Building Cronet framework should be as easy as running the following command from chromium checkout:

components/cronet/tools/package_ios.py -g out/Framework

I've used the following command to generate list of symbols without offsets, but there could be a better way:

symbols -noSources out/Framework/Release-iphoneos/Cronet.framework/Cronet | awk '{$1=""; print $0}'
 

Comment 3 by ajha@chromium.org, Nov 18 2016

Labels: M-56
Components: Internals>Network>Library
If this would help us avoid Issue 593051, that would be awesome and I'd consider this effort much higher priority.
Paul: With respect to Issue 593051, that's not related to CT. That is, the crash would simply move to some other stack, because it's something clobbering the memory.
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)

Sign in to add a comment