server_management_lib: DevserverPushTask should respect the host_server config option; prompt when updating all |
||||||||
Issue descriptionhttps://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/devserver-management The config for devserver related operations has two fields. DevserverPushTask uses one of these configs, and doesn't respect the other one at all. This is very confusing. Today I was provisioning a new Devserver. The provision (on attempt 2) failed because devserver had already been partly provisioned, and the script didn't like that (upstart job devserver already running...), so, I said, let's treat this like we're updating the devserver, so I used the DevserverPushTask. But, it ignored the host_server config option, and happily went about updating all the devservers out there.... (1) let's respect that config option. Respecting only half of a config file is dangerous. (2) If the field is missing / value is empty, we can take that to mean update all (very useful!), but then, let's prompt the user before rebuilding the world.
,
Nov 22 2016
Charlene already has plans for this.
,
Nov 29 2016
,
Jan 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/409440a953c51849e722eda06cd2da9fa83682e6 commit 409440a953c51849e722eda06cd2da9fa83682e6 Author: Shuqian Zhao <shuqianz@chromium.org> Date: Wed Dec 07 23:32:59 2016
,
Jan 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/409440a953c51849e722eda06cd2da9fa83682e6 commit 409440a953c51849e722eda06cd2da9fa83682e6 Author: Shuqian Zhao <shuqianz@chromium.org> Date: Wed Dec 07 23:32:59 2016
,
Feb 2 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pprabhu@chromium.org
, Nov 17 2016