New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666158 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

server_management_lib: DevserverPushTask should respect the host_server config option; prompt when updating all

Project Member Reported by pprabhu@chromium.org, Nov 17 2016

Issue description

https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/devserver-management


The config for devserver related operations has two fields. DevserverPushTask uses one of these configs, and doesn't respect the other one at all.
This is very confusing.

Today I was provisioning a new Devserver. The provision (on attempt 2) failed because devserver had already been partly provisioned, and the script didn't like that (upstart job devserver already running...), so, I said, let's treat this like we're updating the devserver, so I used the DevserverPushTask.

But, it ignored the host_server config option, and happily went about updating all the devservers out there....


(1) let's respect that config option. Respecting only half of a config file is dangerous.
(2) If the field is missing / value is empty, we can take that to mean update all (very useful!), but then, let's prompt the user before rebuilding the world.
 
Cc: jrbarnette@chromium.org shuqianz@chromium.org
Cc: -shuqianz@chromium.org pprabhu@chromium.org
Owner: shuqianz@chromium.org
Status: Assigned (was: Untriaged)
Charlene already has plans for this.

Comment 3 by autumn@chromium.org, Nov 29 2016

Labels: -current-issue
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/409440a953c51849e722eda06cd2da9fa83682e6

commit 409440a953c51849e722eda06cd2da9fa83682e6
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Wed Dec 07 23:32:59 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/409440a953c51849e722eda06cd2da9fa83682e6

commit 409440a953c51849e722eda06cd2da9fa83682e6
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Wed Dec 07 23:32:59 2016

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment