New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666157 link

Starred by 1 user
Status: Verified
Owner:
█ morsed@chromium.org
User never visited
Closed: Jan 2017
Cc:
abodenha@chromium.org
weifangsun@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Get Help: single line of text not translating

Project Member Reported by morsed@google.com, Nov 17 2016 
Version: all
OS: Chrome

What steps will reproduce the problem?
(1) Open the Get Help app
(2) Scroll down in Discover content
(3) In Edit Photos section, find text with link: Edit photos easily with the built-in image edito. Try it now by opening any photo file from the Files app.
(4) Switch Chromebook to any language other than English

What is the expected result?

Sentence translates to respective language.

What happens instead?

Sentence does not translate into any non-English languages.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 25 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/8821b3c672bd60988b4ad6b51e65408cd35a615b

commit 8821b3c672bd60988b4ad6b51e65408cd35a615b
Author: David Morse <morsed@google.com>
Date: Fri Dec 23 02:48:21 2016

Comment 2 by morsed@google.com, Dec 27 2016

Labels: Merge-Request-56
We have translations now for this bug and  crbug.com/648715 .  They landed in M57 (9121.0.0/57.0.2962.0), and I'd like to merge them back to M56.  No new code.  See https://chrome-internal-review.googlesource.com/#/c/314177/

Comment 3 by morsed@google.com, Dec 27 2016 

For the record, the solution to this single line of text not translating was an edit to google3/googleclient/chrome/chromeos_genius/_locales/en/messages.json. A variable called "T" was changed to "TAGEND".  The variable name was changed to just "T" in 2013 and this line of text had not translated since then, throwing an error in the Translation Console ["Placeholder name (T) occurs in the message as an overlap of two fragments."].

Comment 4 by dimu@chromium.org, Dec 27 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 2 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 5 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by morsed@google.com, Jan 6 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-56

Comment 8 by morsed@google.com, Jan 18 2017

Status: Fixed (was: Started)

Comment 9 by rookrishna@chromium.org, Feb 6 2017

Status: Verified (was: Fixed)
Chrome 57.0.2987.30/9202.17.0
►

Sign in to add a comment