New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666154 link

Starred by 7 users
Status: Fixed
Owner:
reed@google.com
Closed: Nov 2016
Cc:
ajha@chromium.org
gov...@chromium.org
█ manoranj...@chromium.org
nyerramilli@chromium.org
█ bustamante@chromium.org
hcm@chromium.org
ligim...@chromium.org
█ tkonch...@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Print preview for PDFs fail

Project Member Reported by thestig@chromium.org, Nov 17 2016 
Version: r432678 ToT build
OS: Linux

What steps will reproduce the problem?
(1) Open a PDF
(2) Print preview

What is the expected result?

See a print print preview

What happens instead?

Received signal 11 <unknown> 000000000000
#0 0x7f6dedc27a5e base::debug::StackTrace::StackTrace()
#1 0x7f6dedc2759f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f6dee073330 <unknown>
#3 0x7f6deb02ab0c SkCanvas::getDevice()
#4 0x7f6deafc2e9b skia::GetMetaData()
#5 0x7f6de21cf215 printing::MetafileSkiaWrapper::GetMetafileFromCanvas()
#6 0x7f6de8a1c40b content::PepperPluginInstanceImpl::PrintPDFOutput()
#7 0x7f6de8a1c261 content::PepperPluginInstanceImpl::PrintPageHelper()
#8 0x7f6de8a1c60a content::PepperPluginInstanceImpl::PrintEnd()
#9 0x7f6de8a5e2c1 content::PepperWebPluginImpl::printEnd()
#10 0x7f6dde00cbad blink::WebPluginContainerImpl::printEnd()
#11 0x7f6dddff0c41 blink::ChromePluginPrintContext::end()
#12 0x7f6dddfe4f8a blink::WebLocalFrameImpl::printEnd()
#13 0x7f6df2aeb64a printing::PrepareFrameAndViewForPrint::FinishPrinting()

This is similar to bug 664036, but caused by r432481.

Comment 1 by thestig@chromium.org, Nov 17 2016

Cc: msrchandra@chromium.org nyerramilli@chromium.org
 Issue 666181  has been merged into this issue.

Comment 2 by tkonch...@chromium.org, Nov 17 2016

Cc: tkonch...@chromium.org
Labels: -ReleaseBlock-Beta ReleaseBlock-Dev OS-Mac OS-Windows
This issue is seen on all PDFs across all platforms and is blocking todays dev release.

Hence tagging with RBD

Comment 3 by tkonch...@chromium.org, Nov 17 2016

Cc: manoranj...@chromium.org gov...@chromium.org ligim...@chromium.org bustamante@chromium.org

Comment 4 Deleted

Comment 5 by ajha@chromium.org, Nov 17 2016

Cc: ajha@chromium.org
Labels: hasbisect-per-revision
Bisected this on Linux Ubuntu 14.04.

Last good build: 56.0.2920.0
First bad build: 56.0.2922.0 (no 56.0.2921.0 available)

Changelog: https://chromium.googlesource.com/chromium/src/+log/e299953842a5913ea92cfeb6f0079acfb22ea407..aaa2bba38197c0bcaa7cbcf15281ef4f9d568818

Note: Ran the hasbisect-per-revision and on the invoked official build, print preview doesn't open on clicking the print icon(considered bad build) and on good build print preview opens and no crash is seen.

Comment 6 by manoranj...@chromium.org, Nov 17 2016 

reed@, could you please land a fix/revert ASAP? This is a blocker for our Dev release.

Thank you!
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 17 2016

Labels: FoundIn-M-56 Fracas
Users experienced this crash on the following builds:

Win Canary 56.0.2922.0 -  43.78 CPM, 163 reports, 137 clients (signature printing::MetafileSkiaWrapper::GetMetafileFromCanvas)
Win Canary 56.0.2922.0 -  124.62 CPM, 464 reports, 409 clients (signature skia::GetMetaData)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 8 by manoranj...@chromium.org, Nov 17 2016 

The revert (https://codereview.chromium.org/2515433002/) has been created couple of hours back, however the try jobs are failing. Checking with reed@.

Thank you!

Comment 9 by manoranj...@chromium.org, Nov 17 2016 

Here is the manual revert: https://codereview.chromium.org/2509983004/

Thank you reed@.

Comment 10 by nasko@chromium.org, Nov 17 2016 

Issue 666425 has been merged into this issue.

Comment 11 by reed@google.com, Nov 17 2016 

experimental alternate fix: https://codereview.chromium.org/2512783002/

Comment 12 by thestig@chromium.org, Nov 17 2016 

I can give the alternate fix a try, but my knowledge of that code is slightly rusty so I eyeball it and say whether it's good or not.

Comment 13 by reed@chromium.org, Nov 17 2016 

Same here, tho the change and its revert are also in the same domain, so its not clear that the alternate is any less risky :)

I locally applied it on linux, and it seems to allow printing.

Comment 14 by thestig@chromium.org, Nov 17 2016 

The alternate CL has some red trybots for other reasons, but seems to work for me too. Maybe ask halcanary and see what he thinks?

Comment 15 by reed@chromium.org, Nov 17 2016 

I've been tracking/fixing them. Just issues around forward-declarations etc. I think. Crossing my fingers on patch-set-4

Comment 16 by manoranj...@chromium.org, Nov 18 2016 

reed@, could you please let us know where we are with the fix/revert to 2922? We need to have a build ASAP with the above revert merged to 2922.

Appreciate your help!

Comment 17 by ananthak@google.com, Nov 18 2016 

We are suppose to branch today. Please land your change ASAP.

Comment 18 by hcm@chromium.org, Nov 18 2016

Cc: hcm@chromium.org
See https://codereview.chromium.org/2518443002/ Mike and Lei have been working on a fix, still trying to get trybots to succeed.
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5afa233cc6b4eff679a2e6fbac926567ac5bf17

commit c5afa233cc6b4eff679a2e6fbac926567ac5bf17
Author: reed <reed@google.com>
Date: Fri Nov 18 06:44:20 2016

Revert "Change call-sites now that SkCanvas is not ref-counted"

This reverts commit 60c148ef13aed978fcaf5dae9e242f99618f2164.
https://codereview.chromium.org/2476113002/

BUG= 666154 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=esprehn@chromium.org,blundell@chromium.org,ccameron@chromium.org,danakj@chromium.org,fmalita@chromium.org,khushalsagar@chromium.org,raymes@chromium.org,sky@chromium.org,tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2509983004
Cr-Commit-Position: refs/heads/master@{#433136}

[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/android_webview/native/java_browser_view_renderer_helper.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/blimp/test/support/compositor/picture_cache_test_support.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/blimp/compositor_state_deserializer_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/blimp/picture_data_conversions_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/output/software_renderer.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/output/software_renderer.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/playback/discardable_image_map.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/playback/discardable_image_map.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/chrome/browser/android/compositor/layer/crushed_sprite_layer.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/chrome/browser/android/compositor/layer/crushed_sprite_layer.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/components/test_runner/pixel_dump.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/browser/compositor/software_output_device_mac.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/browser/compositor/software_output_device_mac.mm
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/browser/compositor/software_output_device_win.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/browser/compositor/software_output_device_win.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/renderer/pepper/ppb_image_data_impl.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/content/renderer/pepper/ppb_image_data_impl.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ppapi/proxy/ppb_image_data_proxy.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ppapi/proxy/ppb_image_data_proxy.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/config/SkUserConfig.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/analysis_canvas_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/bitmap_platform_device_cairo.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/bitmap_platform_device_mac.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/bitmap_platform_device_mac_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/bitmap_platform_device_skia.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/bitmap_platform_device_win.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/platform_canvas.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/platform_canvas.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/platform_canvas_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/skia/ext/skia_utils_mac.mm
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/gfx/blit_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/gfx/canvas.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/gfx/canvas.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/surface/transport_dib.h
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/surface/transport_dib_posix.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/surface/transport_dib_win.cc
[modify] https://crrev.com/c5afa233cc6b4eff679a2e6fbac926567ac5bf17/ui/views/border_unittest.cc

Comment 20 by thestig@chromium.org, Nov 18 2016

Status: Fixed (was: Assigned)
The revert landed, but we don't know when the branch cut is yet, so this may or may not need a M56 merge.

Comment 21 by ajha@chromium.org, Nov 18 2016 

Per C#16, revert needs to be merged to 2922 branch for pushing to the Dev channel. There is no need of "Merge-Request" process, since 2922 is yet to be branched officially.

Comment 22 by manoranj...@chromium.org, Nov 18 2016 

We have to merge the revert to 2924 as well along with 2922.

Thank you!
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 18 2016

Labels: merge-merged-2922
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2392ebaa30e3404f7d319bf2eea62669f9427a7

commit b2392ebaa30e3404f7d319bf2eea62669f9427a7
Author: reed <reed@google.com>
Date: Fri Nov 18 18:00:35 2016

Revert "Change call-sites now that SkCanvas is not ref-counted"

This reverts commit 60c148ef13aed978fcaf5dae9e242f99618f2164.
https://codereview.chromium.org/2476113002/

BUG= 666154 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=esprehn@chromium.org,blundell@chromium.org,ccameron@chromium.org,danakj@chromium.org,fmalita@chromium.org,khushalsagar@chromium.org,raymes@chromium.org,sky@chromium.org,tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2509983004
Cr-Commit-Position: refs/heads/master@{#433136}
(cherry picked from commit c5afa233cc6b4eff679a2e6fbac926567ac5bf17)

NOTRY=True
NOPRESUBMIT=True

Review-Url: https://codereview.chromium.org/2514023002
Cr-Commit-Position: refs/branch-heads/2922@{#6}
Cr-Branched-From: 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511}

[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/android_webview/native/java_browser_view_renderer_helper.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/blimp/test/support/compositor/picture_cache_test_support.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/blimp/compositor_state_deserializer_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/blimp/picture_data_conversions_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/output/software_renderer.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/output/software_renderer.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/playback/discardable_image_map.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/playback/discardable_image_map.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/chrome/browser/android/compositor/layer/crushed_sprite_layer.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/chrome/browser/android/compositor/layer/crushed_sprite_layer.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/components/test_runner/pixel_dump.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/browser/compositor/software_output_device_mac.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/browser/compositor/software_output_device_mac.mm
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/browser/compositor/software_output_device_win.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/browser/compositor/software_output_device_win.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/renderer/pepper/ppb_image_data_impl.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/content/renderer/pepper/ppb_image_data_impl.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ppapi/proxy/ppb_image_data_proxy.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ppapi/proxy/ppb_image_data_proxy.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/config/SkUserConfig.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/analysis_canvas_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/bitmap_platform_device_cairo.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/bitmap_platform_device_mac.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/bitmap_platform_device_mac_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/bitmap_platform_device_skia.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/bitmap_platform_device_win.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/platform_canvas.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/platform_canvas.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/platform_canvas_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/skia/ext/skia_utils_mac.mm
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/gfx/blit_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/gfx/canvas.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/gfx/canvas.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/surface/transport_dib.h
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/surface/transport_dib_posix.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/surface/transport_dib_win.cc
[modify] https://crrev.com/b2392ebaa30e3404f7d319bf2eea62669f9427a7/ui/views/border_unittest.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 18 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba

commit e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba
Author: Mike Reed <reed@google.com>
Date: Fri Nov 18 18:19:15 2016

Revert "Change call-sites now that SkCanvas is not ref-counted"

This reverts commit 60c148ef13aed978fcaf5dae9e242f99618f2164.
https://codereview.chromium.org/2476113002/

BUG= 666154 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

TBR=esprehn@chromium.org,blundell@chromium.org,ccameron@chromium.org,danakj@chromium.org,fmalita@chromium.org,khushalsagar@chromium.org,raymes@chromium.org,sky@chromium.org,tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2509983004
Cr-Commit-Position: refs/heads/master@{#433136}
(cherry picked from commit c5afa233cc6b4eff679a2e6fbac926567ac5bf17)

Review URL: https://codereview.chromium.org/2519513002 .

Cr-Commit-Position: refs/branch-heads/2924@{#4}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/android_webview/native/java_browser_view_renderer_helper.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/blimp/test/support/compositor/picture_cache_test_support.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/blimp/compositor_state_deserializer_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/blimp/picture_data_conversions_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/output/software_renderer.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/output/software_renderer.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/playback/discardable_image_map.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/playback/discardable_image_map.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/chrome/browser/android/compositor/layer/crushed_sprite_layer.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/chrome/browser/android/compositor/layer/crushed_sprite_layer.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/components/test_runner/pixel_dump.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/browser/compositor/software_output_device_mac.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/browser/compositor/software_output_device_mac.mm
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/browser/compositor/software_output_device_win.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/browser/compositor/software_output_device_win.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/renderer/pepper/ppb_image_data_impl.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/content/renderer/pepper/ppb_image_data_impl.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ppapi/proxy/ppb_image_data_proxy.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ppapi/proxy/ppb_image_data_proxy.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/config/SkUserConfig.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/analysis_canvas_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/bitmap_platform_device_cairo.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/bitmap_platform_device_mac.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/bitmap_platform_device_mac_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/bitmap_platform_device_skia.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/bitmap_platform_device_win.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/platform_canvas.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/platform_canvas.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/platform_canvas_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/skia/ext/skia_utils_mac.mm
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/compositor/paint_recorder.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/gfx/blit_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/gfx/canvas.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/gfx/canvas.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/surface/transport_dib.h
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/surface/transport_dib_posix.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/surface/transport_dib_win.cc
[modify] https://crrev.com/e669bb95b7fcb0e75ae7482ee66d66bbc96eb8ba/ui/views/border_unittest.cc

Comment 25 by manoranj...@chromium.org, Nov 19 2016

Labels: TE-Verified-56.0.2922.1
Tested the above revert (c#23) on Chrome#56.0.2922.1 for Win7 64-bit, Mac OS X 10.11.6 and Linux Ubuntu 14.04 - Working as intended, no crash is seen after print preview.

Thank you!
►

Sign in to add a comment