New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666152 link

Starred by 6 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

Support PGO with Clang

Project Member Reported by inglorion@chromium.org, Nov 17 2016

Issue description

r257133 introduced chrome_pgo_phase to allow building Chrome with profile-guided optimization. Thus far, support for this has only
been implemented for MSVC on Windows. We should support this for Clang, too.
 
Blocking: 82385

Comment 2 by ajha@chromium.org, Nov 18 2016

Labels: M-56
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0454d1c39637beb1fb084bea057d614f6908a7ae

commit 0454d1c39637beb1fb084bea057d614f6908a7ae
Author: inglorion <inglorion@chromium.org>
Date: Fri Dec 02 23:04:19 2016

Add the possibility to build with PGO when using Clang

r257133 introduced chrome_pgo_phase to allow building Chrome with
profile-guided optimization. Thus far, support for this has only
been implemented for MSVC on Windows. This change allows PGO to
be used with Clang, as well.

BUG= 666152 

Review-Url: https://codereview.chromium.org/2507333002
Cr-Commit-Position: refs/heads/master@{#436067}

[modify] https://crrev.com/0454d1c39637beb1fb084bea057d614f6908a7ae/build/config/compiler/compiler.gni
[add] https://crrev.com/0454d1c39637beb1fb084bea057d614f6908a7ae/build/config/compiler/pgo/BUILD.gn
[add] https://crrev.com/0454d1c39637beb1fb084bea057d614f6908a7ae/build/config/compiler/pgo/pgo.gni
[modify] https://crrev.com/0454d1c39637beb1fb084bea057d614f6908a7ae/chrome/BUILD.gn

Cc: laszio@chromium.org llozano@chromium.org gmx@chromium.org
Sebastian pointed me to this bug. Just wanted to mention that on Chrome OS we use AFDO (sampled PGO) with Clang. We currently train using benchmarks. We are working in a project to get PGO training set from profiles from the field. Also finding a set of benchamarks that aproximate user behavior. Maybe you can use some of this when you are ready.
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment