Autotest code to enable ARC leaves chrome://settings tab open |
||||||||
Issue descriptionWhen I pass arc_mode='enabled' to autotest's Chrome class's c'tor, it leaves a chrome://settings tab open. I think that this is coming from enable_arc_setting() in client/common_lib/cros/arc_util.py -- it navigates the first tab to chrome://settings, but doesn't appear to do anything with it after it's done. I'd like to look into making this code open a new tab instead and then close it when it's done.
,
Nov 17 2016
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/be39cd54afe24d6cc346689ab81c03147e7290ef commit be39cd54afe24d6cc346689ab81c03147e7290ef Author: Daniel Erat <derat@chromium.org> Date: Thu Nov 17 23:45:26 2016 autotest: Use new tab for ARC setting and close afterward. Make arc_util's enable_arc_setting() function create a new tab for loading chrome://settings and close it when done. It previously just navigated the first tab (assuming there'd be one, I think) and left it open. Also inline some JavaScript code that was wrapped due to being stored in one-off local variables. BUG= chromium:666146 TEST=manually checked that new tab is opened for settings and closed when done Change-Id: Idac7966c4fbd8670a41107220572a5c7b895a49a Reviewed-on: https://chromium-review.googlesource.com/412286 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Chung-yih Wang <cywang@google.com> [modify] https://crrev.com/be39cd54afe24d6cc346689ab81c03147e7290ef/client/common_lib/cros/arc_util.py
,
Nov 19 2016
,
Nov 21 2016
Issue 666871 has been merged into this issue.
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by drinkcat@chromium.org
, Nov 17 2016