Issue 666145 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	zmo@chromium.org
Closed:	Feb 2017
Cc:	█ kbr@chromium.org kainino@chromium.org █ qiankun....@intel.com vmi...@chromium.org piman@chromium.org yunchao...@intel.com
Components:	Blink>WebGL
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug
Security_Impact-Head

Sampling from uninitialized textures

Project Member Reported by zmo@chromium.org, Nov 17 2016

Issue description

In GPU command buffer's draw calls, we look at the current program, and check all the uniforms that are samplers, and then go to the corresponding bound textures, and clear them if uninitialized.

However, at the moment we don't count ES3 specific samplers, thus leaving 3D textures / integer textures potentially uncleared.

A new WebGL2 conformance test caught this.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e6600b56cad269e4a8640c330847a18f2b7df12

commit 5e6600b56cad269e4a8640c330847a18f2b7df12
Author: zmo <zmo@chromium.org>
Date: Thu Nov 17 04:27:44 2016

ES3 sampler types and their corresponding textures should be initialized before being sampled.

BUG= 666145 
TEST=webgl2_conformance (to be added)
R=kbr@chromium.org,piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2503403003
Cr-Commit-Position: refs/heads/master@{#432740}

[modify] https://crrev.com/5e6600b56cad269e4a8640c330847a18f2b7df12/gpu/command_buffer/service/context_state.h
[modify] https://crrev.com/5e6600b56cad269e4a8640c330847a18f2b7df12/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/5e6600b56cad269e4a8640c330847a18f2b7df12/gpu/command_buffer/service/program_manager.h