New issue
Advanced search Search tips

Issue 666144 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up -Wsigned-enum-bitfield

Project Member Reported by h...@chromium.org, Nov 17 2016

Issue description

It's a new Clang warning.

I will suppress it for now, but we need to clean up the source, or enable it selectively for certain third-party libraries if we don't want to change those.
 

Comment 1 by sashab@chromium.org, Nov 17 2016

Cc: esprehn@chromium.org loyso@chromium.org
This is probably some kind of duplicate of crbug.com/648462.

If you look at that bug, there have been a bunch of patches landed for it to either suppress it for a third-party repo (like skia) or fix the places where it's being fired.

I think, at the very least, it should be safe to enable for third_party/WebKit. I think there's one place there that fires the warning but it's an easy fix.

Comment 2 by sashab@chromium.org, Nov 17 2016

Owner: sashab@chromium.org
I'll also take ownership of this :)

Comment 3 by h...@chromium.org, Nov 17 2016

It seems the warning was removed from -Wmost in Clang, which means it's not enabled by default for us anymore:

New Revision: 287193

URL: http://llvm.org/viewvc/llvm-project?rev=287193&view=rev
Log:
Remove -Wsigned-enum-bitfield from -Wmost. On a wide set of ABIs, this warning
is completely irrelevant, producing (effectively) false positives, and -Wmost
is used pretty widely. We should somehow turn it back on by default when
targeting the MS ABI, however, since it indicates the program will not do as
intended in those cases.

(Or perhaps we should just treat enum bitfields as having the signedness of the
enum, even when targeting the MS ABI...)

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticGroups.td
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td




I suppose that's better, as we can turn it on explicitly when our code is ready.
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 20 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ----
Status: Available (was: Untriaged)
Shifting focus to work on ChromeOS.
Cc: -sashab@chromium.org
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment