Re-enable some tests in UserCloudPolicyManagerChromeOSTest. |
||
Issue descriptionThe memory corruption due to the wrong static_cast has been fixed ( Issue 534733 ). I'm trying to re-enable the tests, but the following tests are still failling due to other reason. - UserCloudPolicyManagerChromeOSTest.BlockingFetchTimeout - UserCloudPolicyManagerChromeOSTest.BlockingRefreshFetch - UserCloudPolicyManagerChromeOSTest.NonBlockingFirstFetch - UserCloudPolicyManagerChromeOSTest.NonBlockingRefreshFetch We need to fix a cause and reenable them separately.
,
Nov 17 2016
I have fixes for those tests locally, just waiting for FakeChromeUserManager to be a real ChromeUserManager (I have a CL in progress to re-implement FakeChromeUserManager locally, but happy to wait for you to land https://codereview.chromium.org/2504513002/ since it's identical to my change)
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/786755daa476c2374428a8950377f58f4d709349 commit 786755daa476c2374428a8950377f58f4d709349 Author: atwilson <atwilson@chromium.org> Date: Wed Nov 30 14:36:39 2016 Re-enabled UserCloudPolicyManagerChromeOS unit tests Changed test code to no longer maintain a parallel list of default policies, but instead to use the auto-generated list for easier maintenance. BUG= 666122 Review-Url: https://codereview.chromium.org/2534983002 Cr-Commit-Position: refs/heads/master@{#435257} [modify] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc [modify] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h [modify] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc [modify] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/browser/policy/cloud/cloud_policy_browsertest.cc [add] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/browser/policy/cloud/cloud_policy_test_utils.cc [add] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/browser/policy/cloud/cloud_policy_test_utils.h [modify] https://crrev.com/786755daa476c2374428a8950377f58f4d709349/chrome/test/BUILD.gn
,
Dec 2 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by yoshiki@chromium.org
, Nov 17 2016