Ctrl+X causes quick_launch to hang. |
||||
Issue descriptionType something in quick_launch, press ctrl+a, then press ctrl-x. It hangs. The same scenario in browser's address bar doesn't hang. It also doesn't hang if no text is selected. Currently, InputMethodMus sends the ctrl-x key-event to IME Server, and it calls a callback to tell if the event was handled by IME or not. If it is not handled, DispatchKeyEventPostIME() is called which uses EventSource::SendEventToProcessor() to do local event dispatching. In the case of ctrl-x, this function doesn't return. I tried changing the code to short-cut the path for ctrl-x so it doesn't go through IME server and is handled locally, it still had the same problem.
,
Nov 17 2016
Since it's ctrl-x that causes the problem, perhaps it's something to do with clipboard? Is ClipboardMus doing some sync IPC with mus and not getting the response back or something?
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7f3104c87c624b39cb0df461bd45c29bf8387c9 commit f7f3104c87c624b39cb0df461bd45c29bf8387c9 Author: moshayedi <moshayedi@chromium.org> Date: Thu Nov 17 22:54:50 2016 Fix Ctrl-A then Ctrl-X infinite loop in quick_launch. Before this change, QuickLaunchUI::ContentsChanged() went to an infinite loop if (!suggestion_rejected_ && new_contents.length() == 0). This is because base::ReplaceSubstringsAfterOffset() expects a non-empty string to find. If DCHECK is off, this function goes to an infinite loop, otherwise it crashes. BUG= 666113 Review-Url: https://codereview.chromium.org/2505283003 Cr-Commit-Position: refs/heads/master@{#433000} [modify] https://crrev.com/f7f3104c87c624b39cb0df461bd45c29bf8387c9/mash/quick_launch/quick_launch.cc
,
Nov 17 2016
,
Feb 26 2018
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by moshayedi@chromium.org
, Nov 16 2016