New issue
Advanced search Search tips

Issue 666111 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 508725



Sign in to add a comment

imported/wpt/service-worker tests being run as [Pass Failure]

Project Member Reported by jsb...@chromium.org, Nov 16 2016

Issue description

Following https://codereview.chromium.org/2497193002/ we run w/ --enable-wptserve by default.

TestExpectations has:

 crbug.com/602693  imported/wpt/service-workers [ Failure ]

WPTServeExpectations has:

 crbug.com/602693  imported/wpt/service-workers [ Pass ]

Together this apparently means that the tests run as [ Pass Failure ] so we're not detecting failures (!)

I believe the correct thing to do here is merge WPTServeExpectations entries into TextExpectations, dedupe, and and remove support for it.
 

Comment 1 by tkent@chromium.org, Nov 16 2016

Owner: tkent@chromium.org
Status: Assigned (was: Available)
I'll remove WTPServeExpectations.

Excellent, thanks Kent

Comment 3 by jsb...@chromium.org, Nov 17 2016

Blocking: 508725
Since I had changes ready that merge the contents of the files (and rebaseline some of the tests that fail differently ( issue 508728 ) I've got that uploaded and headed to the CQ.

I'll leave it to tkent@ to wrangle the code changes.

This should take care of  issue 508725  as a side effect
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e831429bc4c93f3ff505ce56f1835babac6eef9d

commit e831429bc4c93f3ff505ce56f1835babac6eef9d
Author: jsbell <jsbell@chromium.org>
Date: Fri Nov 18 03:07:13 2016

Initial TestExpectations vs. WPTServeExpectations cleanup

Now that --enable-wptserve is on by default we don't need
an override expectations file.

BUG= 666111 
R=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2509753003
Cr-Commit-Position: refs/heads/master@{#433041}

[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/WPTServeExpectations
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/FileAPI/url/url_xmlhttprequest-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createElement-namespace-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/002-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-parent-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-src-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-src-about-blank-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/009-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/010-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/history_pushstate_err-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/history_replacestate_err-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/offline/application-cache-api/api_status_idle-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/offline/application-cache-api/api_update-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/origin-of-data-document-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/Window-document-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/the-lang-attribute-003-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-obsolete-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-base-element/base_href_specified-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-iframe-element/same_origin_parentage-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/form-submission-0/getactionurl-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/historical-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/scripting-1/the-script-element/script-onerror-insertion-point-2-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setInterval-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-data-url-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setInterval-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setTimeout-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https-expected.txt
[delete] https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https-expected.txt
[add] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt
[modify] https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d/third_party/WebKit/LayoutTests/imported/wpt/webrtc/simplecall-expected.txt

Comment 5 by tkent@chromium.org, Nov 18 2016

Owner: jsb...@chromium.org
Status: Fixed (was: Assigned)
jsbell@, thank you!

Comment 6 by jsb...@chromium.org, Nov 18 2016

\o/ 

My hands are sore from hitting "commit" so many times. :P


Sign in to add a comment