Issue metadata
Sign in to add a comment
|
1.2%-1.3% regression in sizes at 432145:432145 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 16 2016
davidben: is it possible that your CL regressed window's mini_installer sizes? +grt for win sizes ownership
,
Nov 16 2016
,
Nov 16 2016
This CL? https://codereview.chromium.org/2484803007 If I'm reading this graph right, that's a 500k increase. That CL certainly was not expected to come with a meaningful size increase, and certainly not that much. I looked through the BoringSSL change and don't see any plausible way for it to have done so. (Does mini_installer even use BoringSSL's SSL bits? I thought it just pulled in one or two low-level crypto algorithms and that was it. Or am I thinking something else?) I do notice that it dropped by what looks like the same amount earlier. The drop seems to point at https://codereview.chromium.org/2501243002. I can only assume mini_installer is not pulling in WebGL! Am I using the tool wrong?
,
Nov 16 2016
I don't know. grt, can you take a look?
,
Nov 17 2016
mini_installer is the full installer that contains all of Chrome. It's worth checking for a corresponding increase in something like chrome.dll or another file that's included in the distribution. I'll take a look to see if there's something obvious.
,
Nov 17 2016
From the Chromium waterfall continuous archive, I see a 17,920 byte increase between r432142 and r432145. Looking in the mini_installer, chrome.packed.7z grew by 17,907 bytes. Looking in there, I see that chrome.dll grew by 1024 bytes and that chrome_child.dll grew by 2048 bytes. I suppose this shuffling had an impact on the way the compression algorithm works. If the actual builds used to generate the ChromiumPerf/win graphs are available, I'm happy to take a look at them. Otherwise, I think there's nothing to see here.
,
Nov 17 2016
You can click the "Buildbot stdio" link on the perf dashboard chart tooltips to get back to the sizes log, then truncate the url to get to the buildbot status page, which has a link to the build, but it only goes back to https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/builds/34763 and this is build 34510 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jessimb@chromium.org
, Nov 16 2016