New issue
Advanced search Search tips

Issue 666049 link

Starred by 9 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Accessibility

Blocked on:
issue 829945



Sign in to add a comment

aria-activedescendant changes in list boxes are not announced by screen readers

Project Member Reported by aboxhall@chromium.org, Nov 16 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Example URL:
https://google.github.io/closure-library/source/closure/goog/demos/autocomplete-basic.html
https://cookiecrook.com/test/aria/multiselect/listbox.html

Steps to reproduce the problem:
Use a screen reader (e.g. ChromeVox or VoiceOver on Mac) and an ARIA listbox (potentially as part of an autocomplete widget).
1. If using an autocomplete widget, start typing in the textarea in order for the autocomplete list to popup 
2. navigate in the listbox using up/down arrow (in the example HTML this will change the aria-activedescendant property of the listbox)

What is the expected behavior?
The content of the option identified by the aria-activedescendant property should be announced to the screen readers.

This works with: FF + VoiceOver on Mac, Safari + VoiceOver on Mac IE/FF + JAWS on Windows

What went wrong?
The contents are not announced.

Does not work with: Chrome + ChromeVox on Linux/Mac/Windows, Safari + VoiceOver on Mac

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? No 

Chrome version: 31.0.1650.63  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 11.9 r900
 
Cc: ligim...@chromium.org aboxhall@chromium.org dmazz...@chromium.org
 Issue 326926  has been merged into this issue.
Labels: NewComponent-Accessibility-Blink
This is likely to be related to https://bugs.webkit.org/show_bug.cgi?id=167671
Labels: NewComponent-Accessibility
Components: Blink>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-blink -newcomponent-accessibility
Labels: triage-alice
aria-activedescendant options are read when the role is textbox, but not when the role is combobox. See https://codepen.io/jessebeach/pen/GvrQdP for a demonstration.
Labels: -triage-alice
Labels: triage-dougt
Labels: -triage-dougt
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37c197117dac5e465250f159e1969da26f37ed4

commit f37c197117dac5e465250f159e1969da26f37ed4
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Sep 27 17:53:44 2017

Split the accessible combo box role into three roles.

For historical reasons, the ARIA role "combobox" is misused
and misunderstood. It can be one of three things:

1. A fully editable text field that also has a drop-down list
   of possible options
2. A button that opens to reveal a mutually-exclusive list of
   choices (but with no text field anywhere)
3. A grouping container with a text field and a drop-down list
   inside

The only platform where this mostly worked was on Windows,
where "combo box" is a native control. On Mac and Android,
we need to treat #1 as a text field primarily, and #2 more
like a button, since there's no equivalent that acts as
both.

Bug:  516869 , 666049, 546051
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7ffd92f2996c729398d4300262e545eaa9ca0009
Reviewed-on: https://chromium-review.googlesource.com/642056
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504725}
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_auralinux.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_manager_win.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-autocomplete-expected-android.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-autocomplete-expected-blink.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-autocomplete.html
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-haspopup-expected-android.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-haspopup-expected-blink.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-orientation-expected-android.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-orientation-expected-blink.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-orientation-expected-mac.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-readonly-expected-android.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-readonly-expected-blink.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-readonly-expected-win.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/aria/aria-readonly.html
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-collapse-expected-mac.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-collapse-expected-win.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-focus-expected-mac.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-next-expected-mac.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
[add] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/html/input-list-expected-blink.txt
[add] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/html/input-list-expected-win.txt
[add] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/html/input-list.html
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/html/input-suggestions-source-element-expected-android.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/content/test/data/accessibility/html/input-suggestions-source-element-expected-win.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable-expected.txt
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable.html
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AXEnums.cpp
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AXEnums.h
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/AccessibilityObjectModelTest.cpp
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/tools/accessibility/rebase_dump_accessibility_tree_test.py
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/f37c197117dac5e465250f159e1969da26f37ed4/ui/accessibility/platform/ax_snapshot_node_android_platform.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac626bae03bd67587d9b37cee18bd45eedd040ee

commit ac626bae03bd67587d9b37cee18bd45eedd040ee
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Sep 27 19:31:51 2017

Revert "Split the accessible combo box role into three roles."

This reverts commit f37c197117dac5e465250f159e1969da26f37ed4.

Reason for revert: <INSERT REASONING HERE>

Causing layout test failure on Mac10.9
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/50208

Original change's description:
> Split the accessible combo box role into three roles.
> 
> For historical reasons, the ARIA role "combobox" is misused
> and misunderstood. It can be one of three things:
> 
> 1. A fully editable text field that also has a drop-down list
>    of possible options
> 2. A button that opens to reveal a mutually-exclusive list of
>    choices (but with no text field anywhere)
> 3. A grouping container with a text field and a drop-down list
>    inside
> 
> The only platform where this mostly worked was on Windows,
> where "combo box" is a native control. On Mac and Android,
> we need to treat #1 as a text field primarily, and #2 more
> like a button, since there's no equivalent that acts as
> both.
> 
> Bug:  516869 , 666049, 546051
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I7ffd92f2996c729398d4300262e545eaa9ca0009
> Reviewed-on: https://chromium-review.googlesource.com/642056
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504725}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,michaelpg@chromium.org,aleventhal@chromium.org

Change-Id: I4a3c390bd6c363f531ed00f1faa5fb660f637d16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  516869 , 666049, 546051
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/688354
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504752}
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_auralinux.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_manager_win.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-autocomplete-expected-android.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-autocomplete-expected-blink.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-autocomplete.html
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-haspopup-expected-android.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-haspopup-expected-blink.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-orientation-expected-android.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-orientation-expected-blink.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-orientation-expected-mac.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-readonly-expected-android.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-readonly-expected-blink.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-readonly-expected-win.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/aria/aria-readonly.html
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-collapse-expected-mac.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-collapse-expected-win.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-focus-expected-mac.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-next-expected-mac.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
[delete] https://crrev.com/a82cce3dad3017b30ee256814b4c7d9e67289029/content/test/data/accessibility/html/input-list-expected-blink.txt
[delete] https://crrev.com/a82cce3dad3017b30ee256814b4c7d9e67289029/content/test/data/accessibility/html/input-list-expected-win.txt
[delete] https://crrev.com/a82cce3dad3017b30ee256814b4c7d9e67289029/content/test/data/accessibility/html/input-list.html
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/html/input-suggestions-source-element-expected-android.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/content/test/data/accessibility/html/input-suggestions-source-element-expected-win.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable-expected.txt
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable.html
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AXEnums.cpp
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AXEnums.h
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/AccessibilityObjectModelTest.cpp
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/tools/accessibility/rebase_dump_accessibility_tree_test.py
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/ac626bae03bd67587d9b37cee18bd45eedd040ee/ui/accessibility/platform/ax_snapshot_node_android_platform.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c51580d489ccd4a81f5516c347a19bcabd95215

commit 8c51580d489ccd4a81f5516c347a19bcabd95215
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Nov 17 18:32:56 2017

Re-land: Split the accessible combo box role into three roles.

Original: https://chromium-review.googlesource.com/c/chromium/src/+/642056
Reverted: https://chromium-review.googlesource.com/c/chromium/src/+/688354

Fix just required rebaselining some tests.

For historical reasons, the ARIA role "combobox" is misused
and misunderstood. It can be one of three things:

1. A fully editable text field that also has a drop-down list
   of possible options
2. A button that opens to reveal a mutually-exclusive list of
   choices (but with no text field anywhere)
3. A grouping container with a text field and a drop-down list
   inside

The only platform where this mostly worked was on Windows,
where "combo box" is a native control. On Mac and Android,
we need to treat #1 as a text field primarily, and #2 more
like a button, since there's no equivalent that acts as
both.

Bug:  516869 , 666049, 546051
TBR: dtseng, aleventhal, michaelpg
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idd47a98b396cf8862bde000af43c447d2b9fa921
Reviewed-on: https://chromium-review.googlesource.com/692704
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517483}
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility_auralinux.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-autocomplete-expected-android.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-autocomplete-expected-blink.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-autocomplete.html
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-haspopup-expected-android.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-haspopup-expected-blink.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-orientation-expected-android.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-orientation-expected-blink.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-orientation-expected-mac.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-readonly-expected-android.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-readonly-expected-blink.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-readonly-expected-win.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/aria/aria-readonly.html
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-collapse-expected-mac.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-collapse-expected-win.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-next-expected-mac.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
[add] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/html/input-list-expected-blink.txt
[add] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/html/input-list-expected-win.txt
[add] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/html/input-list.html
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/html/input-suggestions-source-element-expected-android.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/content/test/data/accessibility/html/input-suggestions-source-element-expected-win.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable-expected.txt
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable.html
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AXEnums.cpp
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AXEnums.h
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/AccessibilityObjectModelTest.cpp
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/tools/accessibility/rebase_dump_accessibility_tree_test.py
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/8c51580d489ccd4a81f5516c347a19bcabd95215/ui/accessibility/platform/ax_snapshot_node_android_platform.cc

I see this bug has been open for about a year and half now and the status is still “available.” This one is a real problem for us at Slack. Can someone provide an update as to if this will be fixed, and if so, when?

To provide more insight into things on our end: we’re setting aria-autocomplete to “list” and using the ARIA “textbox” role on the input. This pattern works in Safari, but, as Alice noted in her original comment, in Chrome none of the changes to aria-activedescendant are announced by VoiceOver.

Considering most Slack customers are using our electron app, our customers would really benefit from a fix here.
Blockedon: 829945
It seems that the relevant bug in the last comment has been fixed. Could we test again?
Labels: a11y-testers
Labels: -Pri-3 -a11y-testers OS-Mac Pri-1
Chrome: 68.0.3439.0 Canary
OS: MACOS 10.13.3

The examples in  issue 829945  work well.
However, the example in this issue still does not work.


Project Member

Comment 20 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54e50674f6daa850def14795337f6ae5fed08233

commit 54e50674f6daa850def14795337f6ae5fed08233
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Fri Jun 15 19:38:59 2018

Activedescendant and listbox fixes for Mac a11y

General fixes for active descendant and list boxes on Mac.
- Introduce missing focusedAncestor property. Also, since there are 3 properties that always point
to an ancestor. Group them together in the code and do not expose for root of contents.
(Note: this is now similar to related WebKit code).
- In a list, do not force focus to the listbox, as this breaks ARIA list boxes, by causing focus
events to not be fired for active descendant changes. It also appears to be unnecessary despite the
provided code comment.

Bug: 666049, 829945 
Change-Id: I14c8c6836f2bb26d9ae0fe43d3e1b4d200abd413
Reviewed-on: https://chromium-review.googlesource.com/1096060
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567766}
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/browser/accessibility/accessibility_tree_formatter_mac.mm
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/browser/accessibility/browser_accessibility_manager_mac.mm
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/aria/aria-activedescendant-expected-blink.txt
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/aria/aria-activedescendant-expected-mac.txt
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/aria/aria-activedescendant.html
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/aria/aria-listbox-aria-selected-expected-blink.txt
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/aria/aria-listbox-aria-selected-expected-mac.txt
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/aria/aria-listbox-aria-selected.html
[modify] https://crrev.com/54e50674f6daa850def14795337f6ae5fed08233/content/test/data/accessibility/event/listbox-next-expected-mac.txt

Sign in to add a comment