New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 666042 link

Starred by 2 users
Status: Fixed
Owner:
█ abakalov@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ djweiss@chromium.org
█ zkoch@chromium.org
█ groby@chromium.org
█ riesa@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Merging into M55 a CL switching the new language detector with the old one

Project Member Reported by abakalov@chromium.org, Nov 16 2016 
We'd like to merge the following CL into M55:
https://codereview.chromium.org/2504823002/

It switches the new language detector (CLD3) with the old one (CLD2). The reason is that we haven't had the time to evaluate CLD3 on an additional dataset. Collecting this data took longer than expected.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c945729a79bd09f1ac542ad2b8baf0a5752152f

commit 5c945729a79bd09f1ac542ad2b8baf0a5752152f
Author: abakalov <abakalov@chromium.org>
Date: Wed Nov 16 20:42:35 2016

Switching from CLD3 to CLD2

This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp

patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)

We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.

BUG= 666042 

Review-Url: https://codereview.chromium.org/2504823002
Cr-Commit-Position: refs/heads/master@{#432615}

[modify] https://crrev.com/5c945729a79bd09f1ac542ad2b8baf0a5752152f/third_party/cld/BUILD.gn
[modify] https://crrev.com/5c945729a79bd09f1ac542ad2b8baf0a5752152f/third_party/cld_2/BUILD.gn

Comment 2 by abakalov@chromium.org, Nov 16 2016

Cc: groby@chromium.org djweiss@chromium.org zkoch@chromium.org riesa@chromium.org
Labels: Merge-Request-55

Comment 3 by gov...@chromium.org, Nov 16 2016 

Is this change applicable to all os or any specific OS?

Comment 4 by abakalov@chromium.org, Nov 16 2016

Labels: OS-All
It's applicable to all OS.

Comment 5 by dimu@chromium.org, Nov 17 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db84fddae052da654954a03a56b88c0d384136e6

commit db84fddae052da654954a03a56b88c0d384136e6
Author: Rachel Blum <groby@google.com>
Date: Thu Nov 17 21:43:13 2016

Switching from CLD3 to CLD2

This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp

patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)

We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.

BUG= 666042 

Review-Url: https://codereview.chromium.org/2504823002
Cr-Commit-Position: refs/heads/master@{#432615}
(cherry picked from commit 5c945729a79bd09f1ac542ad2b8baf0a5752152f)

Review URL: https://codereview.chromium.org/2511263002 .

Cr-Commit-Position: refs/branch-heads/2883@{#602}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/db84fddae052da654954a03a56b88c0d384136e6/third_party/cld/BUILD.gn
[modify] https://crrev.com/db84fddae052da654954a03a56b88c0d384136e6/third_party/cld_2/BUILD.gn

Comment 7 by abakalov@chromium.org, Nov 21 2016

Status: Fixed (was: Untriaged)
Thanks, Rachel, for merging the CL! 
Marking this bug as fixed.
►

Sign in to add a comment