Clean up telemetry logging |
||||||||||
Issue descriptionTelemetry logging is full of spam, android in particular. This makes it hard to debug failures. I am working on a document to fully analyze the usefulness of logging on all the different platforms. My first goal is to lessen the amount of "bin/adb devices" spam. https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Galaxy_S5_Perf__2_%2F3750%2F%2B%2Frecipes%2Fsteps%2Fsystem_health.common_mobile.reference%2F0%2Fstdout On the above link that line appears 551 times.
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/244af7aef810b1f263f97a2c6d2651d4d9178e02 commit 244af7aef810b1f263f97a2c6d2651d4d9178e02 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Nov 17 22:17:39 2016 Roll src/third_party/catapult/ af9e00e66..22f8db356 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/af9e00e6653a..22f8db35661b $ git log af9e00e66..22f8db356 --date=short --no-merges --format='%ad %ae %s' 2016-11-17 rnephew [Telemetry] Decrease WPR port logging. BUG=666040 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2508803008 Cr-Commit-Position: refs/heads/master@{#432990} [modify] https://crrev.com/244af7aef810b1f263f97a2c6d2651d4d9178e02/DEPS
,
Nov 17 2016
Currently the stdio page for each step contains the full json sent to the dashboard. That is also included on a separate page with only the json results. I think it would make sense to remove it from the stdio. It is often large and makes the page load slowly. Thoughts on this?
,
Nov 17 2016
I would love to remove it from the stdio, it's way easier to get to from the separate page.
,
Nov 17 2016
I think the json on the stdio it not useful. We already be able to view in in the json results link.
,
Nov 17 2016
It turns out the new luci-logdog changes already do this for us. Since everything will eventually be moving to that, it might be better just to train people to use it now and not worry about making changes that will be overwritten in the near(ish?) future. old: https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/4384/steps/smoothness.key_silk_cases.reference/logs/stdio new: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Galaxy_S5_Perf__1_%2F4384%2F%2B%2Frecipes%2Fsteps%2Fsmoothness.key_silk_cases.reference%2F0%2Fstdout
,
Nov 18 2016
[Telemetry] Turn off checking if device is online after getting healthy devices. Results: /adb devices instances before: 1665 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%281%29/builds/3800/steps/system_health.memory_mobile/logs/stdio /adb devices instances after : 370 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%281%29/builds/3802/steps/system_health.memory_mobile/logs/stdio
,
Nov 18 2016
It seems like using logdog is better overall; in addition to not having the JSON in stdio it stays around longer. The only problem I have with logdog is that it's hard for sheriffs to find. Two things I think would make it easier: 1) Change perf dashboard stdio links to point to logdog. We'd want to change both the upload of link->dashboard, and write a converter for existing ones. 2) Change the recipe annotation to only spit out the link to logdog. Any reason not to do those? +benhenry in case there is someone on infra team we should ask.
,
Nov 18 2016
[Telemetry] Decrease WPR port logging. Results: WPR ports: instances before: 877, 885 https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%283%29/builds/4150/steps/system_health.memory_desktop/logs/stdio https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%283%29/builds/4152/steps/system_health.memory_desktop/logs/stdio WPR ports: instances after: 168, 168 https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%283%29/builds/4154/steps/system_health.memory_desktop/logs/stdio https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%283%29/builds/4153/steps/system_health.memory_desktop/logs/stdio
,
Nov 18 2016
Hey Dan - PTAL comment #8. Stephen added for FYI.
,
Nov 18 2016
All of the changes in #8 are things that would be changed in the recipe and/or dashboard. They sound fine to me.
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3c110924623019fc8316321df24c9d07b9d71aa commit e3c110924623019fc8316321df24c9d07b9d71aa Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Sat Nov 19 05:02:14 2016 Roll src/third_party/catapult/ b506b8ed3..684179fca (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b506b8ed3f35..684179fca1f9 $ git log b506b8ed3..684179fca --date=short --no-merges --format='%ad %ae %s' 2016-11-18 rnephew [Telemetry] Change how telemetry logs size of each trace. BUG=666040 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2519613002 Cr-Commit-Position: refs/heads/master@{#433403} [modify] https://crrev.com/e3c110924623019fc8316321df24c9d07b9d71aa/DEPS
,
Mar 16 2017
WARNING:root:The command to run should preferably be passed as a sequence of args. If shell features are needed (pipes, wildcards, variables) clients should explicitly set shell=True. shows up in the logs a lot. https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5_Perf__3_%2F4725%2F%2B%2Frecipes%2Fsteps%2Floading.mobile%2F0%2Fstdout 1602 times in that log. Lowering the priority on this, seems more p2-ish than p1.
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd936213338a5b35605840b9325f6eca5479bbf7 commit cd936213338a5b35605840b9325f6eca5479bbf7 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Mar 17 02:35:08 2017 Roll src/third_party/catapult/ 4d5136b84..7b2dc0f0d (2 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4d5136b8407e..7b2dc0f0d467 $ git log 4d5136b84..7b2dc0f0d --date=short --no-merges --format='%ad %ae %s' 2017-03-16 eakuefner [Dashboard] Start using /list_tests's test_path_dict mode in test-picker 2017-03-16 rnephew [Devil] Run commands in flag_changer forwarder and perf_control as shell commands. Created with: roll-dep src/third_party/catapult BUG=666040 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2753773007 Cr-Commit-Position: refs/heads/master@{#457662} [modify] https://crrev.com/cd936213338a5b35605840b9325f6eca5479bbf7/DEPS
,
Aug 1
,
Aug 2
,
Aug 24
,
Jan 16
,
Jan 16
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 17 2016