New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 666031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

recipe_engine: overriding two packages

Project Member Reported by no...@chromium.org, Nov 16 2016

Issue description

What steps will reproduce the problem?
(1) fetch infra
(2) git clone https://github.com/luci/recipes-py
(3) ./recipes-py/recipes.py --package infra/infra/config/recipes.cfg -O recipe_engine=./recipes-py/ -O depot_tools=./depot_tools/ run infra_continuous

What is the expected result?
recipe is executed

What happens instead?

Traceback (most recent call last):
  File "./recipes-py/recipes.py", line 646, in <module>
    ret = main()
  File "./recipes-py/recipes.py", line 597, in main
    deps_path=args.deps_path, overrides=args.project_override)
  File "/private/tmp/recipe/repro/recipes-py/recipe_engine/package.py", line 630, in create
    package_deps._register_overrides()
  File "/private/tmp/recipe/repro/recipes-py/recipe_engine/package.py", line 640, in _register_overrides
    self._create_package(repo_spec, True)
  File "/private/tmp/recipe/repro/recipes-py/recipe_engine/package.py", line 645, in _create_package
    return self._create_from_spec(repo_spec, package_spec, overriding)
  File "/private/tmp/recipe/repro/recipes-py/recipe_engine/package.py", line 659, in _create_from_spec
    project_id, (repo_spec, current.repo_spec))
InconsistentDependencyGraphError: Package specs for recipe_engine do not match: PathRepoSpec{path="/private/tmp/recipe/repro/recipes-py"} vs GitRepoSpec{project_id="recipe_engine", repo="https://chromium.googlesource.com/external/github.com/luci/recipes-py.git", branch="master", revision="672570bf06c6b438b353a4c42d4d38ceab089eea", path=""}
Uncaught exception (InconsistentDependencyGraphError): Package specs for recipe_engine do not match: PathRepoSpec{path="/private/tmp/recipe/repro/recipes-py"} vs GitRepoSpec{project_id="recipe_engine", repo="https://chromium.googlesource.com/external/github.com/luci/recipes-py.git", branch="master", revision="672570bf06c6b438b353a4c42d4d38ceab089eea", path=""}
 
Labels: Pri-2
Status: Available (was: Untriaged)
This has been listed as untriaged for over two weeks. Marking available.

Since the priority is P-1, dropping it.

If you disagree with either of these actions (bulk edit), please fix.
This is still not fixed. Can repro with my own infra repo.

We should probably just force an override when you have a PathRepoSpec. Robbie, WDYT?
Status: Fixed (was: Available)
This is now, in fact, fixed.

Sign in to add a comment