New issue
Advanced search Search tips

Issue 666025 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 663471



Sign in to add a comment

Expose RapporService to content/

Project Member Reported by nzolghadr@chromium.org, Nov 16 2016

Issue description

To be able to report some of the existing metrics via RAPPOR we need to expose RapporService to the code in content/.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb

commit d87a308d26eac76bcbcf06fc52e1bfa84d153bfb
Author: nzolghadr <nzolghadr@chromium.org>
Date: Wed Dec 07 15:45:56 2016

Pass RapporService to content/browser/

Pass RapporService instance along with the
current page url to content/browser/renderer_host
to later use it in some metrics.

BUG= 666025 

TBR=droger@chromium.org, gcasto@chromium.org

Review-Url: https://codereview.chromium.org/2510803003
Cr-Commit-Position: refs/heads/master@{#436962}

[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/android/rappor/rappor_service_bridge.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/android/vr_shell/vr_usage_monitor.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/background_sync/background_sync_controller_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/background_sync/background_sync_controller_impl.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/background_sync/background_sync_controller_impl_unittest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/browser_process.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/chromeos/resource_reporter/resource_reporter.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/interstitials/chrome_metrics_helper.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/metrics/chrome_metrics_services_manager_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/plugins/plugin_info_message_filter.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/prefs/pref_metrics_service.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/safe_browsing/srt_fetcher_win.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/tab_contents/navigation_metrics_recorder.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/tab_contents/navigation_metrics_recorder.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/content_settings/content_setting_bubble_model.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/metrics_services_manager/metrics_services_manager.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/metrics_services_manager/metrics_services_manager.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/metrics_services_manager/metrics_services_manager_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/BUILD.gn
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/byte_vector_utils.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/log_uploader.h
[add] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/public/BUILD.gn
[add] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/public/rappor_parameters.h
[add] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/public/rappor_service.h
[rename] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/public/rappor_utils.h
[rename] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/public/sample.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_metric.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_metric.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_parameters.cc
[delete] https://crrev.com/dc72ee94d48e9a7db7e681c790fda82ece1bc3e2/components/rappor/rappor_parameters.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_prefs.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_recorder_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_recorder_impl.h
[rename] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_service_impl.cc
[rename] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_service_impl.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_service_unittest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_utils.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/rappor_utils_unittest.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/reports.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/sample.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/sampler.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/test_rappor_service.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/rappor/test_rappor_service.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/search_engines/template_url_service.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/search_engines/template_url_service.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/security_interstitials/core/metrics_helper.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/components/security_interstitials/core/metrics_helper.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/browser/BUILD.gn
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/browser/DEPS
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/content/public/browser/content_browser_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/application_context.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/application_context_impl.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/ios_chrome_main_parts.mm
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/test/testing_application_context.h
[modify] https://crrev.com/d87a308d26eac76bcbcf06fc52e1bfa84d153bfb/ios/chrome/test/testing_application_context.mm

Comment 2 by jam@chromium.org, Dec 8 2016

Which places in content/ do you want to use this in? Is it going to be a lot of metrics or just a few? If just a few, can this be done in chrome/ (i.e. does it have access to the events/data)?
I'm currently working on the CL that uses this. I'll add you to the CL so you can have a look as soon as I updated it.
Status: Fixed (was: Assigned)

Sign in to add a comment