New issue
Advanced search Search tips

Issue 666019 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 430155



Sign in to add a comment

AnimationWorklet - Add logic for registering new animators in Javascript

Project Member Reported by majidvp@chromium.org, Nov 16 2016

Issue description

This is effectively implements "animationWorklet.registerAnimator" function in animation worklet global scope.

- Validate all the expected static getter values (e.g., inputProperties, inputChildProperties, inputTime, etc...) and throw appropriate errors
- Validate there is a constructor and an animate function
- Create an object to encapsulate the parsed V8 functions (AnimatorDefinition)
- Create a map in worklet scope for name -> AnimatorDefinition

These definition objects will be used when we see an animator assignment in CSS and decide to create/initialize a new animator instance.

 

Comment 1 by flackr@chromium.org, Jan 24 2017

Labels: -Hotlist-Threaded-Rendering Hotlist-ThreadedRendering
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9

commit f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9
Author: majidvp <majidvp@chromium.org>
Date: Wed May 24 14:31:55 2017

Implement |registerAnimator| for AnimationWorklet

|registerAnimator| creates a simple definition model after validation.
It also instantiates at least one animator based on it for testing.

BUG= 666019 

Review-Url: https://codereview.chromium.org/2745823002
Cr-Commit-Position: refs/heads/master@{#474282}

[add] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-registration-expected.txt
[add] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-registration.html
[modify] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.cpp
[modify] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.h
[modify] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.idl
[add] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/Animator.cpp
[add] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/Animator.h
[add] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.cpp
[add] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.h
[modify] https://crrev.com/f09a33ec69c0ad5a9e59c49a9e39291d8fe795d9/third_party/WebKit/Source/modules/compositorworker/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment