New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Use default policy numbers for harness

Project Member Reported by romax@chromium.org, Nov 16 2016

Issue description

We're not using the default numbers which would make it hard to sync the policy used for test harness and the real one.
Should get the values from default one and create the test policy, however the values which should be overridden would remain the customized one.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/602bcbadf2fb102ab8dfcb4f73bda1afa2fa606a

commit 602bcbadf2fb102ab8dfcb4f73bda1afa2fa606a
Author: romax <romax@chromium.org>
Date: Fri Nov 18 22:20:00 2016

[Offline Pages] Fix test harness not using default policy.

Fixed the issue where the test harness was not using the values in default
policy, which would not be easy to track and lead to unexpected results.

BUG= 665990 

Review-Url: https://codereview.chromium.org/2506103002
Cr-Commit-Position: refs/heads/master@{#433312}

[modify] https://crrev.com/602bcbadf2fb102ab8dfcb4f73bda1afa2fa606a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Comment 2 by romax@chromium.org, Nov 18 2016

Status: Fixed (was: Started)

Sign in to add a comment