New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665988 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

crosperf: remove perf binary from toolchain-utils

Project Member Reported by llozano@chromium.org, Nov 16 2016

Issue description

see: 

https://chrome-internal-review.googlesource.com/#/c/157756/

I don't think this is needed anymore and furthermore Yunlian as a patch for perf that we need to use within crosperf. 

We should not have binaries checked in within toolchain-utils.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/5775e7e3e85529f18220d5d6bc47df6c2fc79a6a

commit 5775e7e3e85529f18220d5d6bc47df6c2fc79a6a
Author: Yunlian Jiang <yunlian@google.com>
Date: Mon Jan 23 18:06:55 2017

remove perf binary from toolchain-utils.

This reverts this CL
https://chrome-internal-review.googlesource.com/#/c/157756/,
because the bug in perf is gone.

BUG= chromium:665988 
TEST=run a crosperf with perf, the report report is correct.
     No 20-50% of the report attributed to 'chrome [unknown]'.
     run_test.sh passes.

Change-Id: I4b2b18e9653d95bde5caf076114bf53a84c2a4fd
Reviewed-on: https://chromium-review.googlesource.com/431234
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[delete] https://crrev.com/3fb928efb42405e386da41adf4bd674e86e23022/perf.static
[modify] https://crrev.com/5775e7e3e85529f18220d5d6bc47df6c2fc79a6a/crosperf/results_cache_unittest.py
[modify] https://crrev.com/5775e7e3e85529f18220d5d6bc47df6c2fc79a6a/crosperf/results_cache.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/5775e7e3e85529f18220d5d6bc47df6c2fc79a6a

commit 5775e7e3e85529f18220d5d6bc47df6c2fc79a6a
Author: Yunlian Jiang <yunlian@google.com>
Date: Mon Jan 23 18:06:55 2017

remove perf binary from toolchain-utils.

This reverts this CL
https://chrome-internal-review.googlesource.com/#/c/157756/,
because the bug in perf is gone.

BUG= chromium:665988 
TEST=run a crosperf with perf, the report report is correct.
     No 20-50% of the report attributed to 'chrome [unknown]'.
     run_test.sh passes.

Change-Id: I4b2b18e9653d95bde5caf076114bf53a84c2a4fd
Reviewed-on: https://chromium-review.googlesource.com/431234
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[delete] https://crrev.com/3fb928efb42405e386da41adf4bd674e86e23022/perf.static
[modify] https://crrev.com/5775e7e3e85529f18220d5d6bc47df6c2fc79a6a/crosperf/results_cache_unittest.py
[modify] https://crrev.com/5775e7e3e85529f18220d5d6bc47df6c2fc79a6a/crosperf/results_cache.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment