New issue
Advanced search Search tips

Issue 665981 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 548407



Sign in to add a comment

IME for Mus: Chrome's IMEDriver

Project Member Reported by moshayedi@chromium.org, Nov 16 2016

Issue description

We want to have access to extension based input methods in mus+ash (https://developer.chrome.com/extensions/input_ime).

The browser has access to extensions, so as an initial step we want to have an implementation of IME driver provided by browser.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b171ff9c2c408898b6678001574019efefc42b09

commit b171ff9c2c408898b6678001574019efefc42b09
Author: moshayedi <moshayedi@chromium.org>
Date: Mon Dec 12 23:29:36 2016

IME for Mus: Use ui::InputMethodChromeOS to provide logic for ime driver.

The goal of this CL is to modify content_browser's IMEDriver so we have access
to ui::InputMethodChromeOS's functionality in mus+ash.

This CL:
- Modifies ui::InputMethodChromeOS so it can call an ack callback after
  processing events.
- Introduces InputMethodBridge to acts as a bridge between
  ui::mojom::InputMethod and ui::InputMethodChromeOS.
- Introduces RemoteTextInputClient to send commands received from
  ui::InputMethodChromeOS to a remote client over mojo IPC.
- Modifies content_browser's IMEDriver implementation to use
  ui::InputMethodChromeOS via InputMethodBridge.
- Some unittests to verify that InputMethodBridge works correctly.

BUG= 665981 

Review-Url: https://codereview.chromium.org/2557493002
Cr-Commit-Position: refs/heads/master@{#437955}

[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/ime_driver_mus.cc
[rename] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/ime_driver_mus.h
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.h
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos_unittest.cc
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/remote_text_input_client.cc
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/remote_text_input_client.h
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/simple_input_method.cc
[add] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/browser/ui/views/ime_driver/simple_input_method.h
[delete] https://crrev.com/561b5ae646d076efe21e2cc759b6d97ebb04ab0d/chrome/browser/ui/views/ime_driver_mus.cc
[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/chrome/test/BUILD.gn
[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/ui/aura/mus/text_input_client_impl.cc
[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/ui/base/ime/input_method_chromeos.cc
[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/ui/base/ime/input_method_chromeos.h
[modify] https://crrev.com/b171ff9c2c408898b6678001574019efefc42b09/ui/views/mus/text_input_client_impl.cc

Blockedon: 673769

Comment 3 by sky@chromium.org, Jul 24 2017

Owner: e...@chromium.org

Comment 4 by e...@chromium.org, Sep 12 2017

Owner: thanhph@chromium.org
More IME bugs.
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Owner: xiy...@chromium.org
Blockedon: -673769
Status: Fixed (was: Assigned)
 Issue 673769  is to move IME code out of the browser, which should be part of the new IMF work. Removing it as blocker and close this one.

Sign in to add a comment