New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665978 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 624136



Sign in to add a comment

Switch components/arc/common/buetooth.mojom to use STL types.

Project Member Reported by yusukes@chromium.org, Nov 16 2016

Issue description

Switch components/arc/common/bluetooth.mojom to use STL types.

 crbug.com/662510  has more context. Here are CLs that do the same for other mojom files.

app.mojom:
  https://codereview.chromium.org/2503633003/
enterprise_reporting.mojom:
  https://codereview.chromium.org/2504013003/
video_accelerator.mojom:
  https://codereview.chromium.org/2505733003/

 
puthik@, could you work on the migration?

Blocking: 624136

Comment 3 by puthik@chromium.org, Nov 16 2016

Sure. Look like it's not too much work.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34878653192827ef94e0c34bd94e5be554825822

commit 34878653192827ef94e0c34bd94e5be554825822
Author: puthik <puthik@chromium.org>
Date: Fri Nov 18 20:57:38 2016

arc: bluetooth: enable use_new_wrapper_types for bluetooth.mojom

BUG= 665978 
BUG= 624136 
TEST=trybot, minnie worked fine

Review-Url: https://codereview.chromium.org/2511253002
Cr-Commit-Position: refs/heads/master@{#433293}

[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/BUILD.gn
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/arc_bluetooth_bridge.h
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/bluetooth_struct_traits.h
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/bluetooth_struct_traits_unittest.cc
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/bluetooth_type_converters.cc
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/bluetooth/bluetooth_type_converters_unittest.cc
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/test/fake_bluetooth_instance.cc
[modify] https://crrev.com/34878653192827ef94e0c34bd94e5be554825822/components/arc/test/fake_bluetooth_instance.h

Comment 6 by puthik@chromium.org, Nov 18 2016

Status: Fixed (was: Started)
Thanks a lot!

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment