New issue
Advanced search Search tips

Issue 665969 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add the proper DEPS entries for directories in ios/chrome

Project Member Reported by rohitrao@chromium.org, Nov 16 2016

Issue description

Pre-compute the necessary set of DEPS entries and add them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098884e1c4dbe4a833eaa7bbf55bebbba2186220

commit 098884e1c4dbe4a833eaa7bbf55bebbba2186220
Author: rohitrao <rohitrao@chromium.org>
Date: Mon Dec 05 16:25:46 2016

[ios] Updates ios DEPS files to mirror desktop DEPS files.

Updates ios DEPS files to mirror the desktop DEPS files.  For example, the rules
in ios/DEPS roughly resemble the rules in DEPS, and the rules in ios/chrome/DEPS
roughly resemble the rules in chrome/DEPS.

Also adds some new rules to accomodate iOS code that will be landing in the near
future.

BUG= 665969 

Review-Url: https://codereview.chromium.org/2541083002
Cr-Commit-Position: refs/heads/master@{#436313}

[modify] https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220/ios/DEPS
[modify] https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220/ios/chrome/DEPS
[modify] https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220/ios/chrome/app/DEPS
[modify] https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220/ios/chrome/browser/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c

commit f615b0af7fea1d9dfb86e33a036ca08252b7ce9c
Author: rohitrao <rohitrao@chromium.org>
Date: Thu Dec 15 18:59:10 2016

[ios] Adds specific_include_rules to DEPS files.

BUG= 665969 

Review-Url: https://codereview.chromium.org/2576103002
Cr-Commit-Position: refs/heads/master@{#438885}

[modify] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/app/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/app/application_delegate/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/app/startup/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/autofill/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/browsing_data/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/metrics/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/native_app_launcher/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/sessions/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/snapshots/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/tabs/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/contextual_search/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/downloads/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/history/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/ntp/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/side_swipe/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/stack_view/DEPS
[add] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/ui/tab_switcher/DEPS
[modify] https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c/ios/chrome/browser/web/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment