New issue
Advanced search Search tips

Issue 665967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 665966



Sign in to add a comment

Add BrandedImageProvider

Project Member Reported by rohitrao@chromium.org, Nov 16 2016

Issue description

This provider will vend images that contain product-specific branding.
 
Blocking: 665966
See also  Issue 667563 , which states that sync-related branding might be ok to stay in Chromium builds.

For now I'll put everything behind the provider, because the code is already written.  We can always unwind this later if needed.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8da2b13c765261c6c4890c8386d2cdd4d74201

commit 2c8da2b13c765261c6c4890c8386d2cdd4d74201
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Nov 22 15:19:53 2016

[ios] Adds BrandedImageProvider and its associated image resources.

This provider will vend images that contain embedder-specific branding.

BUG= 665967 

Review-Url: https://codereview.chromium.org/2521493003
Cr-Commit-Position: refs/heads/master@{#433862}

[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_100_percent/contextual_search_header.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_100_percent/promo_info.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_100_percent/settings_info_24.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_200_percent/contextual_search_header.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_200_percent/promo_info.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_200_percent/settings_info_24.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_300_percent/contextual_search_header.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_300_percent/promo_info.png
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/default_300_percent/settings_info_24.png
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/app/theme/ios_theme_resources.grd
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/browser/providers/BUILD.gn
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/browser/providers/chromium_browser_provider.h
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/browser/providers/chromium_browser_provider.mm
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/browser/providers/images/BUILD.gn
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/browser/providers/images/chromium_branded_image_provider.h
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/chrome/browser/providers/images/chromium_branded_image_provider.mm
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/BUILD.gn
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/chrome_browser_provider.h
[modify] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/chrome_browser_provider.mm
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/images/branded_image_provider.h
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/images/branded_image_provider.mm
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/images/test_branded_image_provider.h
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/images/test_branded_image_provider.mm
[add] https://crrev.com/2c8da2b13c765261c6c4890c8386d2cdd4d74201/ios/public/provider/chrome/browser/images/whats_new_icon.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1008025b2f0779e65fa8973a2bb7e00db8215a76

commit 1008025b2f0779e65fa8973a2bb7e00db8215a76
Author: rohitrao <rohitrao@google.com>
Date: Wed Nov 23 02:03:54 2016

Status: Fixed (was: Assigned)

Sign in to add a comment