"SystemTrayTest.NullDefaultViewIsNotRecorded" is flaky |
|||
Issue description"SystemTrayTest.NullDefaultViewIsNotRecorded" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitTeXN0ZW1UcmF5VGVzdC5OdWxsRGVmYXVsdFZpZXdJc05vdFJlY29yZGVkDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 17 2016
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c15af06d9e97c6221cb2c5a62584c43336b963a commit 7c15af06d9e97c6221cb2c5a62584c43336b963a Author: bruthig <bruthig@chromium.org> Date: Thu Nov 17 18:21:57 2016 Disabled SystemTrayTest.NullDefaultViewIsNotRecorded on Windows due to flakiness. BUG= 665960 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2513653002 Cr-Commit-Position: refs/heads/master@{#432916} [modify] https://crrev.com/7c15af06d9e97c6221cb2c5a62584c43336b963a/ash/common/system/tray/system_tray_unittest.cc
,
Nov 18 2016
,
Nov 21 2016
,
Nov 21 2016
I'm not sure it makes sense to disable the test and mark this fixed. Shouldn't the flakiness be resolved and the test re-enabled to be "Fixed"?
,
Nov 21 2016
The test is only disabled on windows and the ash_unittests are soon to be not-run on windows bots. So it could be investigated but I didn't think it was worth it.
,
Nov 21 2016
Ah, gotcha. That seems reasonable, sorry.
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5 commit b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5 Author: jamescook <jamescook@chromium.org> Date: Thu Dec 15 01:31:59 2016 chromeos: Remove OS ifdefs from ash/common/system/tray Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS ifdefs. BUG= 666773 , 665960 TEST=ash_unittests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2576133002 Cr-Commit-Position: refs/heads/master@{#438706} [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/label_tray_view.cc [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/system_tray_notifier.cc [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/system_tray_notifier.h [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/system_tray_unittest.cc [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/tray_image_item.cc [modify] https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5/ash/common/system/tray/tray_notification_view.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by fsam...@chromium.org
, Nov 17 2016Owner: bruthig@chromium.org
Status: Assigned (was: Untriaged)