Hmm, it's on the non-ToT WinClang bots too, so probably not due to a Clang change

The test is very much Chrome-branding specific..

#if defined(GOOGLE_CHROME_BUILD)
  // The name of the Windows updater for Chrome.
  EXPECT_STREQ("Omaha", attributes.at("name").c_str());
#endif  // GOOGLE_CHROME_BUILD

> I don't see it on the non-clang official tester: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64
Wait, that's not an official tester..

The test just looks busted:

TEST_F(UpdaterStateTest, Serialize) {
  UpdaterState updater_state(false);

  updater_state.updater_name_ = "the updater";   <------ Checking here.
  updater_state.updater_version_ = base::Version("1.0");
  updater_state.last_autoupdate_started_ = base::Time::NowFromSystemTime();
  updater_state.last_checked_ = base::Time::NowFromSystemTime();
  updater_state.is_joined_to_domain_ = false;
  updater_state.is_autoupdate_check_enabled_ = true;
  updater_state.update_policy_ = 1;

  auto attributes = updater_state.BuildAttributes();

  // Sanity check all members.
  EXPECT_STREQ("the updater", attributes.at("name").c_str());
  EXPECT_STREQ("1.0", attributes.at("version").c_str());
  EXPECT_STREQ("0", attributes.at("laststarted").c_str());
  EXPECT_STREQ("0", attributes.at("lastchecked").c_str());
  EXPECT_STREQ("0", attributes.at("domainjoined").c_str());
  EXPECT_STREQ("1", attributes.at("autoupdatecheckenabled").c_str());
  EXPECT_STREQ("1", attributes.at("updatepolicy").c_str());

  // Tests some of the remaining values.
  updater_state = UpdaterState(false);

#if defined(GOOGLE_CHROME_BUILD)
  // The name of the Windows updater for Chrome.
  EXPECT_STREQ("Omaha", attributes.at("name").c_str());  <--- Same check here.
#endif  // GOOGLE_CHROME_BUILD


I don't see how that second check can be true given that we already checked that attribute has a different value above.

Fix: https://codereview.chromium.org/2509723003/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c643082c26a563c5983e5a34004471978d59b57b

commit c643082c26a563c5983e5a34004471978d59b57b
Author: hans <hans@chromium.org>
Date: Wed Nov 16 22:13:29 2016

Make UpdaterStateTest.Serialize pass on Chrome-branded builds

BUG= 665951 

Review-Url: https://codereview.chromium.org/2509723003
Cr-Commit-Position: refs/heads/master@{#432641}

[modify] https://crrev.com/c643082c26a563c5983e5a34004471978d59b57b/components/update_client/updater_state_unittest.cc