New issue
Advanced search Search tips

Issue 665923 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

A zero-to-nonzero to 14.6% regression in webrtc_perf_tests at 15037:15038

Project Member Reported by hlundin@chromium.org, Nov 16 2016

Issue description

I suspect this CL: https://chromium.googlesource.com/external/webrtc/+/e6f98c7a379aae970e7570ac3cf99e2a21f256c0

The other CL in the blame range is an automatic chrome roll.

 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=665923

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi92VoQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi_nUsAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi9nFvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi7mxtwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi8rjpwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs6uE5QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg09fb6woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85uSswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg89aLpAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg84TirgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85HyuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs8L-4woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg0-Hv-AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs92A7wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs7-iowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs8O9tgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_jVqgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs6X3pwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85GAsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg87LxoAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs-XotgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs9uPtwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs8X79AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg893gtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg84rrvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85GUqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs7-2sgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_6ppAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs5SG6AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg84rrvwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85vEogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg88aN8woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_LAuQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8-z7qwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg89aVuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg88Dj_wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg84T4twoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs6uEpQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8930rAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_7H7AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85uOqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_KKtQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg86aytwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgs_ni5AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg86zlqQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85ijvAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_7dtQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8-HougkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi9C5vwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg85f1oAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8_ifpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8-vfvQoM


Bot(s) for this bug's original alert(s):

webrtc-linux-large-tests
webrtc-mac-large-tests
webrtc-win-large-tests
Cc: holmer@chromium.org
Status: Started (was: Assigned)
Yes, that seems very plausible.

My first guess is that these tests rely on undocumented behaviour: previously RED over RTX was implicitly enabled whenever RED was enabled. After the suspected CL, this is no longer the case. I'll look into it in detail.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/fbfb536ee94dcebfc2f80ccfea1bbab2b1a4cd69

commit fbfb536ee94dcebfc2f80ccfea1bbab2b1a4cd69
Author: brandtr <brandtr@webrtc.org>
Date: Thu Nov 17 12:18:37 2016

Explicitly enable RED over RTX in rampup tests.

Also remove unused |rtx_ssrc_map_| member.

BUG= chromium:665923 

Review-Url: https://codereview.webrtc.org/2508973002
Cr-Commit-Position: refs/heads/master@{#15127}

[modify] https://crrev.com/fbfb536ee94dcebfc2f80ccfea1bbab2b1a4cd69/webrtc/call/rampup_tests.cc
[modify] https://crrev.com/fbfb536ee94dcebfc2f80ccfea1bbab2b1a4cd69/webrtc/call/rampup_tests.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
The metrics are back up in WebRTC revision #15127.

There will be a bunch of alerts in a day or two :)
Added some of the expected alerts to this bug.

Sign in to add a comment