New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 631513



Sign in to add a comment

android.webkit.cts.WebViewTest#testPrinting is failing on Builder: Android WebView CTS L-MR1 (dbg)

Project Member Reported by tobiasjs@chromium.org, Nov 16 2016

Issue description

Comment 1 by sgu...@chromium.org, Nov 16 2016

Cc: -thestig@chromium.org sgu...@chromium.org
Owner: thestig@chromium.org
let's revert it. We were not full sure when landing either. 

Comment 2 by sgu...@chromium.org, Nov 16 2016

Labels: -Pri-3 Pri-1

Comment 3 by sgu...@chromium.org, Nov 16 2016

I created the revert and in CQ now.
I'm going to try to test reverting locally. I'll get back to you to with any results.
OK. Maybe I'll let the test bot answer that question.

Comment 6 by sgu...@chromium.org, Nov 16 2016

actually to be sure I compiled a webview with this and the printing test passed. Maybe I pulled the trigger too soon?

Comment 7 by sgu...@chromium.org, Nov 16 2016

but looking at the changes that landed in this range, there really is no other possibility, I guess I am making a mistake in my local build.
Blocking: 631513
Cc: creis@chromium.org alex...@chromium.org nasko@chromium.org
Components: Internals>Printing Internals>Sandbox>SiteIsolation
Is there a way to run the failing test with the suspect CL, but without relanding?  I hoped that there would be a trybot that would match the failing builder, but I don't see anything like that under master.tryserver.chromium.android.

I guess we will know for sure if the suspect CL caused the failure after https://luci-milo.appspot.com/buildbot/chromium.android/Android%20arm%20Builder%20(dbg) picks up the revert (r432507 should be included in build #17629) and then https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20(dbg) picks up #17629 for testing.  This is probably still 2-3 hours away...
FWIW, the logs at https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/17958/steps/Run%20CTS/logs/stdio seem to indicate that the test failure is a timeout, but don't tell much more...
sgurun@, please let us know if you are able to repro the failure locally and what the repro steps are.  Please assume next to zero Android-specific knowledge (i.e. I know how to launch the Chromium's Android emulator on Ubuntu + how to build x86/android Chromium build, but don't know how to provision the emulator with the freshly built, private binaries + how to download/setup/run CTS test suite).


Prerequisite; you need to have an android device connected and can use adb

Yes you can run the test locally. Here are the steps:

1. Download cts test binary from 
https://source.android.com/compatibility/cts/downloads.html

Choose the right architecture (arm). cts test for printing should be same in recent versions

2. unzip the binary to a directory
3. use :
./android-cts/tools/cts-tradefed
4. in the prompt enter 
run cts -m CtsWebkitTestCases -t android.webkit.cts.WebViewTest#testPrinting
for running printing test


Comment 12 by boliu@chromium.org, Nov 16 2016

> Yes you can run the test locally. Here are the steps:

imo that's a high bar to clear for a developer not familiar with android. You also have to know how to properly replace the system webview with the one built locally etc.

I think we need a webview developer to help here.
well I am already looking no need to remind.
ok reproed it and it is actually this CL. :( should have reproed it a lot earlier but I've got a local issue.
Doh. I will also try to setup my Android device and repro this. It'll be good to be able to do so as we will make more OOPIF changes in the future.
you don't need cts test to verify (although we are working on a trybot). I can send you an apk that repro'es
Status: Assigned (was: Available)
I mostly followed https://www.chromium.org/developers/how-tos/build-instructions-android-webview - build AOSP 5.1.1, flashed a phone, deleted the system webview, and installed my own (without setting system_webview_package_name). With a small test app from sgurun@, I can reproduce the problem.

Comment 18 by creis@chromium.org, Nov 17 2016

Comment 17: Thanks for getting that set up!  Any progress on the issue causing it to fail?  We'd love to get a fix in before branch if possible, but I know that's cutting it close.
Not yet. I'm looking at a similar build config on Linux which is:

enable_basic_printing = true
enable_print_preview = false

and I see problems. Whereas before I tested with a normal build (both build flags flipped to true) + --disable-print-preview. Either I missed the problem or the two are not quite the same.
Actually ignore comment 19. I had a bad merge locally. I found the real webview problem and will have a new CL out soon.
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb959ce66a9a89b6f100795bb33292439a7ed7de

commit cb959ce66a9a89b6f100795bb33292439a7ed7de
Author: thestig <thestig@chromium.org>
Date: Thu Nov 17 05:56:32 2016

Make printing work better with OOPIF. (try 2)

Fix failing Android WebView CTS tests this time.

BUG= 631513 , 665909 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=nasko@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2508923003
Cr-Commit-Position: refs/heads/master@{#432775}

[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_print_manager.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_print_manager.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_printing_message_filter.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/browser/aw_printing_message_filter.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/aw_print_web_view_helper_delegate.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/aw_print_web_view_helper_delegate.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/android_webview/renderer/print_render_frame_observer.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_message_handler.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_preview_message_handler.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/cocoa/applescript/tab_applescript.mm
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/pepper/chrome_pdf_print_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/chrome/renderer/printing/chrome_print_web_view_helper_delegate.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/browser/print_manager.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/browser/print_manager.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/common/print_messages.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/renderer/print_web_view_helper.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/test/print_test_content_renderer_client.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/public/browser/render_frame_host.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/public/renderer/render_frame_observer.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/public/renderer/render_view_observer.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/renderer/render_frame_impl.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/content/renderer/render_view_impl.cc
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/ipc/ipc_message_macros.h
[modify] https://crrev.com/cb959ce66a9a89b6f100795bb33292439a7ed7de/ipc/ipc_message_templates.h

Status: Fixed (was: Assigned)

Comment 23 by creis@chromium.org, Nov 17 2016

Thanks!  That was some quick work to get it resolved-- much appreciated!
Due to  bug 666193 , we are not 100% in the clear yet. We'll find out in a couple hours.

Comment 25 by creis@chromium.org, Nov 17 2016

Comment 24: Sounds like that bug was due to a different CL?
Yes, but it was masking a small potential failure here. The webview bots went green, so we are all good here.

Comment 27 by creis@chromium.org, Nov 17 2016

Hooray!

Sign in to add a comment