The circle of the app list launcher icon isn't centered. |
|||||||
Issue descriptionChrome: 56.0.2916.0 minnie It looks off to me. I'm not sure if this is due to MD or something else. tdanderson@ any clue?
,
Nov 16 2016
this is because the black circle is 32dp in diameter and the inner ring is 13dp in diameter. There's no way to center it and maintain sharp boundaries. (Hypothetically we could center at 2x dsf, but we don't do that correctly either.) Probably the easiest fix is for Sebastien to change the white ring to 14dp across (i.e. provide a new version of launcher.svg).
,
Nov 16 2016
oh geeze, apparently Sebastien is AFK and the deadline's tomorrow so I'll just make the swaperoo myself and hopefully he's amenable to the fix.
,
Nov 16 2016
14dp sgtm.
,
Nov 16 2016
Sorry about that here are 14x14 version of the launcher assets.
,
Nov 16 2016
Issue 649780 has been merged into this issue.
,
Nov 16 2016
Evan, see Issue 649780 for further details. Also I am going to assign issue 649549 to you as well, it is possible they are related.
,
Nov 16 2016
,
Nov 16 2016
Sebastien, does the above lgty? It preserves the intended radius at 2x dsf and only adjusts it at 1x. Also 1.5x looks nicer, even though we don't presently care about that. I did this without the use of your assets.
,
Nov 16 2016
,
Nov 16 2016
I also noticed that the 2x launcher icon doesn't look quite right when it has focus over a dark blue wallpaper. See attached screenshot. The outer circle of the icon looks slightly brighter than both the icon itself and background.
,
Nov 17 2016
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7f510bb94819ac12386b0624c07ef65ccc059eb commit c7f510bb94819ac12386b0624c07ef65ccc059eb Author: estade <estade@chromium.org> Date: Thu Nov 17 18:48:10 2016 Adjust MD shelf app list icon for better centering. Also fix appearance during shelf auto-hide/show animations (for all three shelf alignments). BUG= 665894 ,649549 Review-Url: https://codereview.chromium.org/2509743002 Cr-Commit-Position: refs/heads/master@{#432927} [modify] https://crrev.com/c7f510bb94819ac12386b0624c07ef65ccc059eb/ash/common/shelf/app_list_button.cc [modify] https://crrev.com/c7f510bb94819ac12386b0624c07ef65ccc059eb/ash/common/shelf/app_list_button.h [modify] https://crrev.com/c7f510bb94819ac12386b0624c07ef65ccc059eb/ash/resources/vector_icons/BUILD.gn [delete] https://crrev.com/6bc89c2f906e60716162495094115425acbd36e9/ash/resources/vector_icons/shelf_app_list.1x.icon [delete] https://crrev.com/6bc89c2f906e60716162495094115425acbd36e9/ash/resources/vector_icons/shelf_app_list.icon
,
Nov 17 2016
I'm not seeing the weird halo from comment 11. The original issue this bug was filed for has been fixed.
,
Nov 28 2016
Verified on ChromeOS 9000.8.0, 56.0.2924.7 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by est...@chromium.org
, Nov 16 2016Status: Assigned (was: Untriaged)