New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665894 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

The circle of the app list launcher icon isn't centered.

Project Member Reported by osh...@chromium.org, Nov 16 2016

Issue description

Chrome: 56.0.2916.0 minnie

It looks off to me. I'm not sure if this is due to MD or something else. tdanderson@ any clue?
 
Screenshot 2016-11-16 at 5.54.50 AM.png
17.6 KB View Download

Comment 1 by est...@chromium.org, Nov 16 2016

Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look since Terry is probably a bit busy today.

Comment 2 by est...@chromium.org, Nov 16 2016

Owner: sgabr...@chromium.org
this is because the black circle is 32dp in diameter and the inner ring is 13dp in diameter. There's no way to center it and maintain sharp boundaries. (Hypothetically we could center at 2x dsf, but we don't do that correctly either.)

Probably the easiest fix is for Sebastien to change the white ring to 14dp across (i.e. provide a new version of launcher.svg).

Comment 3 by est...@chromium.org, Nov 16 2016

Owner: est...@chromium.org
oh geeze, apparently Sebastien is AFK and the deadline's tomorrow so I'll just make the swaperoo myself and hopefully he's amenable to the fix.

Comment 4 by varkha@chromium.org, Nov 16 2016

Cc: tdander...@chromium.org sgabr...@chromium.org tbuck...@chromium.org
Components: UI>Shell>Launcher
Labels: Proj-MaterialDesign-CrOS OS-Chrome
14dp sgtm.
Sorry about that here are 14x14 version of the launcher assets.
launcher-assets.zip
1.3 KB Download
Issue 649780 has been merged into this issue.
Evan, see Issue 649780 for further details. Also I am going to assign issue 649549 to you as well, it is possible they are related.

Comment 8 by est...@chromium.org, Nov 16 2016

Pp3X8O9RDcD.png
41.6 KB View Download

Comment 9 by est...@chromium.org, Nov 16 2016

Sebastien, does the above lgty? It preserves the intended radius at 2x dsf and only adjusts it at 1x. Also 1.5x looks nicer, even though we don't presently care about that.

I did this without the use of your assets.
Cc: abodenha@chromium.org ihf@chromium.org
 Issue 665984  has been merged into this issue.

Comment 11 by h...@chromium.org, Nov 16 2016

I also noticed that the 2x launcher icon doesn't look quite right when it has focus over a dark blue wallpaper.

See attached screenshot. The outer circle of the icon looks slightly brighter than both the icon itself and background.
Screenshot 2016-11-16 at 1.53.04 PM.png
2.1 KB View Download
Status: Started (was: Assigned)
Status: Fixed (was: Started)
I'm not seeing the weird halo from comment 11. The original issue this bug was filed for has been fixed.
Status: Verified (was: Fixed)
Verified on ChromeOS 9000.8.0, 56.0.2924.7

Sign in to add a comment