Issue 665885 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ ivoc@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Cc:	hlundin@chromium.org peah@chromium.org
Components:	Blink>WebRTC
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug-Regression
M-56

2.3%-86.6% regression in webrtc_perf_tests at 15077:15084

Project Member Reported by hlundin@chromium.org, Nov 16 2016

Issue description

I think there are two possible culprits here:

- https://chromium.googlesource.com/external/webrtc/+/b829d9f2eefa9bbfdd10a4dd391b7d1bbfe4a733 ("Add AudioOption for residual echo detector, and enable the echo detector by default on non-mobile platforms")

- https://chromium.googlesource.com/external/webrtc/+/20270be8079e4d974cf7f8dc0b77cc4ca7542e6b ("Make sure that multiband processing is active when the residual echo detector is active")

I think that the former contributes to all graphs, while the latter add further insult to injury on some of the graphs.

Comment 1 by hlundin@chromium.org, Nov 16 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=665885

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy_T0swoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy_C3tQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi8HirQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi_bBrQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi7HAtAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy4iRswkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy-KbpwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi52nuwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi4ulowkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi-_CqQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi9LvuQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy6HfogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy4qpugoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi-O5vAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi6GMpwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi_fn5wsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy_K6-AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy8jDsAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy8jZoQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi4PYoAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgy5aqogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi5GqqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgi6KX_woM


Bot(s) for this bug's original alert(s):

webrtc-linux-large-tests
webrtc-mac-large-tests

Comment 2 by hlundin@chromium.org, Nov 16 2016

Cc: hlundin@chromium.org
Components: Blink>WebRTC
Labels: -M-54 M-56

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/377b60ce110fcdb3f8e9b1ee8629a3371ac0af42

commit 377b60ce110fcdb3f8e9b1ee8629a3371ac0af42
Author: ivoc <ivoc@webrtc.org>
Date: Thu Nov 17 09:04:18 2016

Only enable residual echo detector when needed in level controller perf tests.

BUG= webrtc:6525 , chromium:665885 

Review-Url: https://codereview.webrtc.org/2505983002
Cr-Commit-Position: refs/heads/master@{#15122}

[modify] https://crrev.com/377b60ce110fcdb3f8e9b1ee8629a3371ac0af42/webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc

Comment 4 by ivoc@chromium.org, Dec 19 2016

Status: Fixed (was: Assigned)

►

Issue 665885 link

Issue metadata

2.3%-86.6% regression in webrtc_perf_tests at 15077:15084

Issue description

Comment 1 by hlundin@chromium.org, Nov 16 2016

Comment 1 Deleted

Comment 2 by hlundin@chromium.org, Nov 16 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

Comment 3 Deleted

Comment 4 by ivoc@chromium.org, Dec 19 2016

Comment 4 Deleted

Sign in to add a comment