m_hasDataChannels field not initialized correctly in blink::RTCPeerConnection |
|||||
Issue descriptionThis field should be initialized as false. This affects RAPPOR metric collection.
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81bc06645eda2bc80ac82983824418b6dab9dcec commit 81bc06645eda2bc80ac82983824418b6dab9dcec Author: guidou <guidou@chromium.org> Date: Wed Nov 16 16:35:31 2016 Correctly initialize m_hasDataChannels field in RTCPeerConnection BUG= 665884 Review-Url: https://codereview.chromium.org/2507783002 Cr-Commit-Position: refs/heads/master@{#432514} [modify] https://crrev.com/81bc06645eda2bc80ac82983824418b6dab9dcec/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
,
Nov 17 2016
,
Nov 18 2016
,
Nov 21 2016
Is it possible to implement testing that ensures members like this one are always properly initialized to prevent similar problems in the future?
,
Dec 6 2016
Ping on MissingTests? It should be easy to write a unit test that checks that a freshly created connection doesn't have any data channels, no?
,
Dec 20 2016
Another ping. Guido: can you please respond to #5?
,
Jan 3 2017
Ping pong
,
Jan 9 2017
Yes. Layout tests should test that. Filed issue 679297.
,
Feb 16 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by guidou@chromium.org
, Nov 16 2016