New issue
Advanced search Search tips

Issue 665884 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

m_hasDataChannels field not initialized correctly in blink::RTCPeerConnection

Project Member Reported by guidou@chromium.org, Nov 16 2016

Issue description

This field should be initialized as false.
This affects RAPPOR metric collection.
 

Comment 1 by guidou@chromium.org, Nov 16 2016

Components: Blink>WebRTC>PeerConnection
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81bc06645eda2bc80ac82983824418b6dab9dcec

commit 81bc06645eda2bc80ac82983824418b6dab9dcec
Author: guidou <guidou@chromium.org>
Date: Wed Nov 16 16:35:31 2016

Correctly initialize m_hasDataChannels field in RTCPeerConnection

BUG= 665884 

Review-Url: https://codereview.chromium.org/2507783002
Cr-Commit-Position: refs/heads/master@{#432514}

[modify] https://crrev.com/81bc06645eda2bc80ac82983824418b6dab9dcec/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Comment 3 by guidou@chromium.org, Nov 17 2016

Status: Fixed (was: Started)
Labels: M-57
Labels: MissingTests
Is it possible to implement testing that ensures members like this one are always properly initialized to prevent similar problems in the future?
Ping on MissingTests? It should be easy to write a unit test that checks that a freshly created connection doesn't have any data channels, no?
Another ping. Guido: can you please respond to #5?
Ping pong
Yes. Layout tests should test that. Filed issue 679297.
Labels: -MissingTests

Sign in to add a comment