Improve content suggestions fetch times and frequency.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43da4b6d12166dc10f397b2f09ace9fd4a7bb33e commit 43da4b6d12166dc10f397b2f09ace9fd4a7bb33e Author: markusheintz <markusheintz@chromium.org> Date: Wed Nov 16 23:44:33 2016 Add a histogram for recording content suggestions local usage time stats. BUG= 665873 Review-Url: https://codereview.chromium.org/2509663002 Cr-Commit-Position: refs/heads/master@{#432662} [modify] https://crrev.com/43da4b6d12166dc10f397b2f09ace9fd4a7bb33e/components/ntp_snippets/content_suggestions_metrics.cc [modify] https://crrev.com/43da4b6d12166dc10f397b2f09ace9fd4a7bb33e/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0ed4eb7afa96fadc7404597c9b5d3b01db1e547 commit b0ed4eb7afa96fadc7404597c9b5d3b01db1e547 Author: markusheintz <markusheintz@chromium.org> Date: Fri Nov 18 12:15:29 2016 Add a count for Suggested Articles usage. BUG= 665873 Review-Url: https://codereview.chromium.org/2510053002 Cr-Commit-Position: refs/heads/master@{#433182} [modify] https://crrev.com/b0ed4eb7afa96fadc7404597c9b5d3b01db1e547/components/ntp_snippets/content_suggestions_metrics.cc [modify] https://crrev.com/b0ed4eb7afa96fadc7404597c9b5d3b01db1e547/tools/metrics/actions/actions.xml
Raising Prio to P2 and setting target to M-57 to properly reflect the importance of this task. No problem if it slips to M-58 though.
Requesting to merge the CL from comment #2 to M56.
Your change meets the bar and is auto-approved for M56 (branch: 2924)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3b0a45fc690bf465c91303d64f75848e7b13bb5 commit d3b0a45fc690bf465c91303d64f75848e7b13bb5 Author: Marc Treib <treib@chromium.org> Date: Wed Nov 23 16:19:14 2016 Add a count for Suggested Articles usage. BUG= 665873 Review-Url: https://codereview.chromium.org/2510053002 Cr-Commit-Position: refs/heads/master@{#433182} (cherry picked from commit b0ed4eb7afa96fadc7404597c9b5d3b01db1e547) Review URL: https://codereview.chromium.org/2528683003 . Cr-Commit-Position: refs/branch-heads/2924@{#75} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d3b0a45fc690bf465c91303d64f75848e7b13bb5/components/ntp_snippets/content_suggestions_metrics.cc [modify] https://crrev.com/d3b0a45fc690bf465c91303d64f75848e7b13bb5/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6f620269ee0af3e7f8da7542a0cf04275248912 commit f6f620269ee0af3e7f8da7542a0cf04275248912 Author: markusheintz <markusheintz@chromium.org> Date: Thu Dec 08 13:02:25 2016 RemoteContentSuggestions: Stores the time of the last successful background fetch in a pref. Therefore we also need to pass the fetch success status to the callback passed to the NTPSnippetsFetcher. The last successful background fetch time will be used by the scheduler in the future in order to decide when to do/schedule the next background fetch. Passing back the success status to the callback will also allow to add error handling. BUG= 665873 ,672422 Review-Url: https://codereview.chromium.org/2549163002 Cr-Commit-Position: refs/heads/master@{#437233} [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/pref_names.cc [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/pref_names.h [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/remote/ntp_snippets_fetcher.cc [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/remote/ntp_snippets_fetcher.h [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/remote/remote_suggestions_provider.cc [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/remote/remote_suggestions_provider.h [modify] https://crrev.com/f6f620269ee0af3e7f8da7542a0cf04275248912/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a393080dc65d0a7f3db31a84b87a9ab66f76c683 commit a393080dc65d0a7f3db31a84b87a9ab66f76c683 Author: markusheintz <markusheintz@chromium.org> Date: Tue Dec 13 14:01:24 2016 Adds histograms for collecting data about Zine usage for each day of the week. The goal is to compare usage patterns between the different days of the week. BUG= 665873 Review-Url: https://codereview.chromium.org/2563443004 Cr-Commit-Position: refs/heads/master@{#438157} [modify] https://crrev.com/a393080dc65d0a7f3db31a84b87a9ab66f76c683/components/ntp_snippets/content_suggestions_metrics.cc [modify] https://crrev.com/a393080dc65d0a7f3db31a84b87a9ab66f76c683/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f611ae761793787a9c970a10fee31f7b23d7bc5 commit 6f611ae761793787a9c970a10fee31f7b23d7bc5 Author: markusheintz <markusheintz@chromium.org> Date: Tue Dec 13 19:50:53 2016 [NTPSnippets] Switch from TickClock to Clock for storing the last background fetched time. Expose the last background fetch time on snippets internals and allow to trigger background fetches manually from snippets internal. BUG= 665873 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2569663004 Cr-Commit-Position: refs/heads/master@{#438262} [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/chrome/browser/resources/snippets_internals.html [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/chrome/browser/resources/snippets_internals.js [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/chrome/browser/ui/webui/snippets_internals_message_handler.h [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/chrome/browser/ui/webui/snippets_internals_ui.cc [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/components/ntp_snippets/remote/remote_suggestions_provider.cc [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/components/ntp_snippets/remote/remote_suggestions_provider.h [modify] https://crrev.com/6f611ae761793787a9c970a10fee31f7b23d7bc5/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad98d7dc609cf909ba2594267071253f83c2cc2f commit ad98d7dc609cf909ba2594267071253f83c2cc2f Author: markusheintz <markusheintz@chromium.org> Date: Thu Dec 15 13:59:23 2016 [NTPSnippets] Records the time since last successful bg fetch. Therefore a new UMA histogram is added. BUG= 665873 Review-Url: https://codereview.chromium.org/2574073003 Cr-Commit-Position: refs/heads/master@{#438823} [modify] https://crrev.com/ad98d7dc609cf909ba2594267071253f83c2cc2f/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/ad98d7dc609cf909ba2594267071253f83c2cc2f/components/ntp_snippets/content_suggestions_metrics.cc [modify] https://crrev.com/ad98d7dc609cf909ba2594267071253f83c2cc2f/components/ntp_snippets/content_suggestions_metrics.h [modify] https://crrev.com/ad98d7dc609cf909ba2594267071253f83c2cc2f/tools/metrics/histograms/histograms.xml
Jan I guess this one is fixed. And superseded by other efforts. Can I close it?
Yes, I think this is addressed.
Comment 1 by bugdroid1@chromium.org
, Nov 16 2016