Findbugs error in ContentShellTestBase |
||
Issue descriptionI just tried a local ninja -C out_android/Debug all with findbugs enabled from an up to date master checkout, and I got: FAILED: gen/content/shell/android/content_shell_test_java__findbugs/result.xml python ../../build/android/findbugs_diff.py --depfile gen/content/shell/android/content_shell_test_java__findbugs.d --exclude ../../build/android/findbugs_filter/findbugs_exclude.xml --auxclasspath-gyp @FileArg\(gen/content/shell/android/content_shell_test_java.build_config:javac:classpath\) --output-file gen/content/shell/android/content_shell_test_java__findbugs/result.xml lib.java/content/shell/android/content_shell_test_java.jar ******************************************************************************** FindBugs run via: java -classpath /ssd/clankium/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m -Dfindbugs.home="/ssd/clankium/src/third_party/findbugs" -jar /ssd/clankium/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /ssd/clankium/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /ssd/clankium/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/ssd/clankium/src/out_android/Debug/lib.java/content/shell/android/content_shell_apk_java.jar:/ssd/clankium/src/out_android/Debug/lib.java/content/shell/android/content_shell_java.jar:/ssd/clankium/src/out_android/Debug/lib.java/base/base_java.jar:/ssd/clankium/src/out_android/Debug/lib.java/base/base_java_test_support.jar:/ssd/clankium/src/out_android/Debug/lib.java/content/public/android/content_java.jar:/ssd/clankium/src/out_android/Debug/lib.java/content/public/test/android/content_java_test_support.jar:/ssd/clankium/src/out_android/Debug/lib.java/content/shell/android/content_shell_java.jar:/ssd/clankium/src/out_android/Debug/lib.java/ui/android/ui_java.jar -exclude /ssd/clankium/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/content/shell/android/content_shell_test_java__findbugs/result.xml /ssd/clankium/src/out_android/Debug/lib.java/content/shell/android/content_shell_test_java.jar FindBugs reported the following issues: IJU_SETUP_NO_SUPER: TestCase defines setUp that doesn't call super.setUp() In class org.chromium.content_shell_apk.ContentShellTestBase In method org.chromium.content_shell_apk.ContentShellTestBase.setUp() Overrides android.test.ActivityInstrumentationTestCase2.setUp() At ContentShellTestBase.java:[line 61] ******************************************************************************** Looking at the code, this error looks justified, but I don't know why we are not seeing this on the bots (maybe this code is never put through findbugs on the bots. The code is recent, so assigning to the author (amaralp@)
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/085701ef9a4ad12ba89368704c4f92f6d8dbccfe commit 085701ef9a4ad12ba89368704c4f92f6d8dbccfe Author: amaralp <amaralp@chromium.org> Date: Wed Nov 16 20:35:03 2016 Call super on ContentShellTestBase#setUp The CL (crrev.com/2465053002) forgot to add a call to |super.setUp()| when it overrode |setUp()|. BUG= 665813 Review-Url: https://codereview.chromium.org/2509023002 Cr-Commit-Position: refs/heads/master@{#432612} [modify] https://crrev.com/085701ef9a4ad12ba89368704c4f92f6d8dbccfe/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java
,
Nov 21 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by aber...@chromium.org
, Nov 16 2016