New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665804 link

Starred by 1 user
Status: Fixed
Owner:
█ msten...@opera.com
NOT IN USE
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Float overlaps with other float when both are pushed below the current line

Reported by msten...@opera.com, Nov 16 2016 
I realized that I probably introduced a regression here:

https://codereview.chromium.org/2486413002/diff/1/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp#newcode3640

But it appears that this didn't work prior to my CL either, at least not for quite some time. It's reproducible in Chrome 53, for instance.

Changing that line of code to actually take the new logical top into account does fix the bug though. :-S
tc.html
450 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92bd951db144e36d9235557a01d18703c2755ce

commit e92bd951db144e36d9235557a01d18703c2755ce
Author: mstensho <mstensho@opera.com>
Date: Wed Nov 16 15:59:19 2016

When placing a float, pay attention to its final logical top.

Subsequent floats may not be placed above this location.

BUG= 665804 

Review-Url: https://codereview.chromium.org/2504173002
Cr-Commit-Position: refs/heads/master@{#432503}

[add] https://crrev.com/e92bd951db144e36d9235557a01d18703c2755ce/third_party/WebKit/LayoutTests/fast/block/float/float-on-line-large-and-small-float-below.html
[modify] https://crrev.com/e92bd951db144e36d9235557a01d18703c2755ce/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Comment 2 Deleted

Comment 3 by amineer@chromium.org, Nov 16 2016 

[Bulk edit]

Branch issues caused these items to be erroneously tagged as merged to branch 2922, please ignore.

Comment 4 by mmoss@chromium.org, Nov 16 2016

Labels: -merge-merged-2922

Comment 5 by msten...@opera.com, Nov 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment