bluetooth: android: align orign in chooser with omnibox |
|||||
Issue descriptionI've noticed while playing too much with Web Bluetooth chooser these days that the origin wasn't aligned vertically and horizontally the same on Chooser and Omnibox. Do you think we could try to match those to make it nicer on transition? See video attached or you can try it yourself by picking "Swipe" at https://github.com/beaufortfrancois/sandbox/commit/01d5514523e04400684160ac0015f951c82611fd?diff=unified This is pure polish. If it's an easy fix for juncai@, let's do it.
,
Nov 17 2016
I think fbeaufort@ meant bottom-aligning rather than left-aligning (so reducing top padding by 1 or 2dp and seeing if they line up better.) It's not necessary to make them aligned, correct, but it could be considered very small polish. I'm OK holding off/archiving if you don't feel strongly.
,
Mar 20 2017
,
Mar 29 2017
Removing myself as design contact. If you need visual support still you can reach out to hannahs@
,
Apr 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
I think trying to keep these in sync doesn't make sense given that padding around text in the omnibox is likely to change as well without looking at all the dialogs that display an origin. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by juncai@chromium.org
, Nov 16 2016