If we do not show offline badges, do not open offline version of a page |
||||
Issue descriptionDepending on whether source URLs are provided for offline pages ( issue 618716 ), we may decide not to show offline badges on NTP suggestions. Then there is no sense to redirect to offline pages from non offline pages related categories (e.g. Articles or Bookmarks), so this should be turned off as well.
,
Nov 18 2016
,
Nov 21 2016
Can I get a little more guidance on this bug, I'm not sure what the issue is. If the user offlines a page (eg. http://en.wikipedia.org/wiki/Cola) which is redirected (eg. https://en.m.wikipedia.org/wiki/Cola - note the addition of mobile and the https version), we check against both of these addresses when deciding to show the offline badge.
,
Nov 21 2016
A clarification from our private discussion: by redirect I mean opening an offline version of a page, when the user clicked on a suggestion, which was offlined before. We should not open offline version of a page, if we do not show a badge. Note, that this is valid only for non offline page based sections (e.g. bookmarks, articles for you). For Downloads and Recent tabs we *should* open an offline version even without a badge.
,
Nov 22 2016
Discussed in UX Weekly. Outcome: if offline badges fails UI Review, that will have implications. BP has passed.
,
Dec 29 2016
This bug is obsolete. Currently we do not force offline version of the page (except for downloads) and it is up to Offline Pages team whether to open offline version of the page (i.e. opening a suggestion is the same as opening a URL). Thus, we simply cannot control which version to open (and there is no sense in doing this). |
||||
►
Sign in to add a comment |
||||
Comment 1 by fi...@chromium.org
, Nov 16 2016