Findbugs error in MediaPlayerBridge |
|||||
Issue descriptionSometimes I am getting the following Findbugs error when I build. Strangely, if I rebuild (with no changes), it goes away. Is this a Findbugs bug? FAILED: gen/media/base/android/media_java__findbugs/result.xml python ../../build/android/findbugs_diff.py --depfile gen/media/base/android/media_java__findbugs.d --exclude ../../build/android/findbugs_filter/findbugs_exclude.xml --auxclasspath-gyp @FileArg\(gen/media/base/android/media_java.build_config:javac:classpath\) --output-file gen/media/base/android/media_java__findbugs/result.xml lib.java/media/base/android/media_java.jar ******************************************************************************** FindBugs run via: java -classpath /ssd/clankium/src/third_party/findbugs/lib/findbugs.jar: -Xmx768m -Dfindbugs.home="/ssd/clankium/src/third_party/findbugs" -jar /ssd/clankium/src/third_party/findbugs/lib/findbugs.jar -textui -sortByClass -pluginList /ssd/clankium/src/tools/android/findbugs_plugin/lib/chromiumPlugin.jar -xml:withMessages -auxclasspath /ssd/clankium/src/third_party/android_tools/sdk/platforms/android-23/android.jar:/ssd/clankium/src/out_android/Debug/lib.java/base/base_java.jar -exclude /ssd/clankium/src/build/android/findbugs_filter/findbugs_exclude.xml -output gen/media/base/android/media_java__findbugs/result.xml /ssd/clankium/src/out_android/Debug/lib.java/media/base/android/media_java.jar FindBugs reported the following issues: DE_MIGHT_IGNORE: Method might ignore exception In class org.chromium.media.MediaPlayerBridge$LoadDataUriTask In method org.chromium.media.MediaPlayerBridge$LoadDataUriTask.doInBackground(Void[]) Exception class java.io.IOException At MediaPlayerBridge.java:[line 265] At MediaPlayerBridge.java:[line 265] ********************************************************************************
,
Nov 16 2016
Chris, this is on Android. Can you take a look?
,
Nov 16 2016
,
Nov 16 2016
From the findbugs sysprops documentation: findbugs.de.comment: Don't report empty catch blocks if a source comment is found in the block. Probably we don't set this, so findbugs is unaware that we have a comment there.
,
Nov 16 2016
Is it warning on this though? https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/StreamUtil.java If not we should just call that.
,
Nov 16 2016
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e32c210161618089232df9572b56d41a18d5e8a8 commit e32c210161618089232df9572b56d41a18d5e8a8 Author: watk <watk@chromium.org> Date: Thu Nov 17 00:21:26 2016 Use StreamUtil#closeQuietly to close a stream in MediaPlayerBridge This is cleaner and will suppress a findbugs warning we had. BUG= 665788 Review-Url: https://codereview.chromium.org/2509113002 Cr-Commit-Position: refs/heads/master@{#432674} [modify] https://crrev.com/e32c210161618089232df9572b56d41a18d5e8a8/media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java
,
Nov 17 2016
These docs says the android_clang_dbg bot should run findbugs: https://chromium.googlesource.com/chromium/src/+/master/docs/use_find_bugs_for_android.md But I don't see it here? https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/165847 I'll assume it's fixed for now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by avayvod@chromium.org
, Nov 16 2016