New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665787 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 666415
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 605219



Sign in to add a comment

Regression : Unable to scroll down the page using scroll bar and scroll bar gets stuck.

Reported by yfulgaon...@etouch.net, Nov 16 2016

Issue description

Chrome Version : 56.0.2920.0 (Official Build) 378fc3fd49ebb678fc98cd99831b858fd304691f-refs/heads/master@{#432057} 64-bit
OS : Mac(10.11.6, 10.12.1, 10.12)

Test URL 1 : http://www.gogi.in/
Test URL 2 : https://in.yahoo.com/?p=us

What steps will reproduce the problem?
1. Launch chrome, navigate to above URL, click on ‘View’ menu in toolbar and disable ‘Always show toolbar..’ option.
2. Click on ‘Full screen’ button in top LHS of toolbar (browser enters into full screen mode).
3. Now click and hold on the upper part of the scroll bar and drag it downwards, observe. (Please review an attached screen cast)

Actual : Unable to scroll down the page using scroll bar and scroll bar gets stuck.
Expected : User should be able to scroll down the page using scroll bar and it should not stuck.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info.
Good Build : 56.0.2886.0
Bad Build : 56.0.2888.0

Note : 
1. Above issue is reproducible only when the page is scrolled down using the ‘upper half’ part of the scrollbar.
2. This is Mac specific issue and the same is working fine on Windows & Linux OS.
3. Issue is not seen in Safari or Firefox browser.
 
Actual_Scrolling.mov
8.7 MB Download
Expected_Scrolling_1.mov
8.8 MB Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Cc: ranjitkan@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on MAC 10.12.1 and is a regression broken in M56. Below are the bisect details for the same:

Good Build : 56.0.2886.0
Bad Build : 56.0.2888.0

Bisect URL: https://chromium.googlesource.com/chromium/src/+/50535c63a1e96b5078bee3724e8cf3b7922b686a
Change log: https://chromium.googlesource.com/chromium/src/+/3c806bffd
Review-Url: https://codereview.chromium.org/2411193002

@ chrishtr: Assigning to you, kindly have a look into it. Please help us to find an owner if not with respect to your change.

Also adding release block label, please undo if not the case.

Thanks.!
Labels: Needs-TestConfirmation
I can't reproduce this on 56.0.2914.3 / OS X 10.12.1 retina. or on 56.0.2920.0 / OS X 10.12.1 retina.

Testers, please test again on those versions.
Cc: kavvaru@chromium.org
Able to reproduce the issue on MAC Retina Pro 10.12.1 Intel HD Graphics 4000 1536 MB using chrome version 57.0.2926.0.Click on top of scroll bar and drag the scroll bar using mouse observed that scroll bar gets stuck.but issue is not consistently reproducible here also(frequency 3/5).

chrishtr@ Could you please look into this issue.

Thanks,
I can reproduce on Chrome Canary / Mac, but not Chromium ToT. Tried with trackpad
and mouse, and both are broken on Canary but work at ToT. Will try again in a few
days.
Now I can't reproduce on Canary. Maybe a commit in the last week fixed this issue.
Will bisect.
Labels: -Needs-TestConfirmation
Mergedinto: 666415
Status: Duplicate (was: Assigned)
Confirmed, this fixed it.
Blocking: 605219
Cc: tapted@chromium.org chrishtr@chromium.org
Labels: -Pri-1 -M-56 -ReleaseBlock-Stable -hasbisect-per-revision Pri-2
Owner: ----
Status: Available (was: Duplicate)
Thanks for the great investigation! I'm going to mark this as a blocker for  Issue 605219  so we make sure we don't regress it if we attempt the fix again.

Comment 11 by sdy@chromium.org, Mar 7 2017

Confirmed that this is brought back by turning on chrome::ShouldUseFullSizeContentView() ( issue 605219 ), but does *not* repro if I just enable Auto Layout ( issue 695577 ).

Comment 12 by sdy@chromium.org, Jul 10 2017

Owner: sdy@chromium.org
Status: Started (was: Available)
CL in progress: https://chromium-review.googlesource.com/c/566030/
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45f7994fbcf0e40e02e4c4823a07b9b6ef28a325

commit 45f7994fbcf0e40e02e4c4823a07b9b6ef28a325
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Jul 11 07:05:57 2017

Enable ShouldUseFullSizeContentView().

Also fixes the known issues with enabling it:

- crbug/665787: The tab background view was added in front of the content and
  blocked interaction with the top of the scroll bar when the toolbar was
  hidden. It's now inserted behind the content, like before.

- crbug/655112: FramedBrowserWindowTest.DoesHideTitle took screenshots of the
  frame view, which gets drawn using a different (layer-backed?) path when
  NSFullSizeContentViewWindowMask is on. The test now calls -[CATransaction
  flush] before taking each screenshot, and uses a different API to screenshot
  the whole window instead of trying to grab just the frame view by accessing
  the content view's superview.

Bug:  605219 ,  655112 ,  665787 ,  730679 ,  734713 ,  737206 
Change-Id: Id78c21aff6748e02fd4b3e461c77ef9f7454d744
Reviewed-on: https://chromium-review.googlesource.com/566030
Commit-Queue: Sidney San Martin <sdy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485544}
[modify] https://crrev.com/45f7994fbcf0e40e02e4c4823a07b9b6ef28a325/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/45f7994fbcf0e40e02e4c4823a07b9b6ef28a325/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
[modify] https://crrev.com/45f7994fbcf0e40e02e4c4823a07b9b6ef28a325/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685e99063e6bac1d4417829ec3b6abdcb918caf6

commit 685e99063e6bac1d4417829ec3b6abdcb918caf6
Author: Keishi Hattori <keishi@chromium.org>
Date: Tue Jul 11 08:55:01 2017

Revert "Enable ShouldUseFullSizeContentView()."

This reverts commit 45f7994fbcf0e40e02e4c4823a07b9b6ef28a325.

Reason for revert: Broke BrowserWindowControllerTest.UsesAutoLayout

Original change's description:
> Enable ShouldUseFullSizeContentView().
> 
> Also fixes the known issues with enabling it:
> 
> - crbug/665787: The tab background view was added in front of the content and
>   blocked interaction with the top of the scroll bar when the toolbar was
>   hidden. It's now inserted behind the content, like before.
> 
> - crbug/655112: FramedBrowserWindowTest.DoesHideTitle took screenshots of the
>   frame view, which gets drawn using a different (layer-backed?) path when
>   NSFullSizeContentViewWindowMask is on. The test now calls -[CATransaction
>   flush] before taking each screenshot, and uses a different API to screenshot
>   the whole window instead of trying to grab just the frame view by accessing
>   the content view's superview.
> 
> Bug:  605219 ,  655112 ,  665787 ,  730679 ,  734713 ,  737206 
> Change-Id: Id78c21aff6748e02fd4b3e461c77ef9f7454d744
> Reviewed-on: https://chromium-review.googlesource.com/566030
> Commit-Queue: Sidney San Martin <sdy@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485544}

TBR=tapted@chromium.org,shrike@chromium.org,sdy@chromium.org

Change-Id: I00b73bc5d2d5607736ddc81b9ae81ec65527ebad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  605219 ,  655112 ,  665787 ,  730679 ,  734713 ,  737206 
Reviewed-on: https://chromium-review.googlesource.com/566898
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485564}
[modify] https://crrev.com/685e99063e6bac1d4417829ec3b6abdcb918caf6/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/685e99063e6bac1d4417829ec3b6abdcb918caf6/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
[modify] https://crrev.com/685e99063e6bac1d4417829ec3b6abdcb918caf6/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a20a025fb10592190b5b3bc90fd627c45c76676a

commit a20a025fb10592190b5b3bc90fd627c45c76676a
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Jul 11 18:39:06 2017

Enable ShouldUseFullSizeContentView().

Also fixes the known issues with enabling it:

- crbug/665787: The tab background view was added in front of the content and
  blocked interaction with the top of the scroll bar when the toolbar was
  hidden. It's now inserted behind the content, like before.

- crbug/655112: FramedBrowserWindowTest.DoesHideTitle took screenshots of the
  frame view, which gets drawn using a different (layer-backed?) path when
  NSFullSizeContentViewWindowMask is on. The test now calls -[CATransaction
  flush] before taking each screenshot, and uses a different API to screenshot
  the whole window instead of trying to grab just the frame view by accessing
  the content view's superview.

This is a re-land of r485544 (reverted in r485564) with a test fix for
BrowserWindowControllerTest.UsesAutoLayout.

Bug:  605219 ,  655112 ,  665787 ,  730679 ,  734713 ,  737206 
Change-Id: I59c03e90b30613285df89a1b3694f36de3f1a7d8
Reviewed-on: https://chromium-review.googlesource.com/567205
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martin <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485682}
[modify] https://crrev.com/a20a025fb10592190b5b3bc90fd627c45c76676a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
[modify] https://crrev.com/a20a025fb10592190b5b3bc90fd627c45c76676a/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/a20a025fb10592190b5b3bc90fd627c45c76676a/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
[modify] https://crrev.com/a20a025fb10592190b5b3bc90fd627c45c76676a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Comment 16 by sdy@chromium.org, Jul 12 2017

Status: Fixed (was: Started)

Sign in to add a comment