New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665752 link

Starred by 1 user
Status: Verified
Owner:
alemate@chromium.org
Closed: Jan 2017
Cc:
omrilio@chromium.org
█ elizabethchiu@chromium.org
█ rookrishna@chromium.org
sdantul...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD OOBE: Different modals

Project Member Reported by dhadd...@chromium.org, Nov 16 2016 
During MD OOBE, on the GOogle Chrome OS Terms page,

"System security setting" and the "Learn more" links both open modals.
One makes the background go white. 
One makes the go dark. 

This is a bit inconsistent

Comment 1 by alemate@chromium.org, Jan 19 2017

Owner: elizabethchiu@chromium.org
I can replace TPM background with another one, but I don't know which one.
I tried to find what background "Ash Modal Dialog" is using, but did not succeed yet.

Comment 2 by alemate@chromium.org, Jan 19 2017

Owner: alemate@chromium.org

Comment 3 by alemate@chromium.org, Jan 19 2017

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505b49d17e4048c3dbd4aad632e324c0174cee4b

commit 505b49d17e4048c3dbd4aad632e324c0174cee4b
Author: alemate <alemate@chromium.org>
Date: Fri Jan 20 09:23:26 2017

ChromeOS OOBE: make "System Security Settings" popup dialog backgroung gray.

This CL makes background style of "System Security Settings" look like
"Help App" background dialog that can be launched from the same UI.

BUG= 604119 , 665752 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648623002
Cr-Commit-Position: refs/heads/master@{#445024}

[modify] https://crrev.com/505b49d17e4048c3dbd4aad632e324c0174cee4b/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/505b49d17e4048c3dbd4aad632e324c0174cee4b/chrome/browser/resources/chromeos/login/oobe_popup_overlay.css

Comment 5 by alemate@chromium.org, Jan 23 2017

Labels: -M-56 M-57 Merge-Request-57
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 27 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 31 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by dhadd...@chromium.org, Feb 8 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-57
OOBE is not going into M57 now

Comment 10 by rookrishna@chromium.org, Feb 23 2017

Status: Verified (was: Fixed)
Chrome OS 58.0.3015.0/9310.0
►

Sign in to add a comment