New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression:Delay is seen while loading contents of 'Saved Passwords' in chrome://md-settings

Reported by adha...@etouch.net, Nov 16 2016

Issue description

Chrome Version:56.0.2920.0 (Official Build) 378fc3fd49ebb678fc98cd99831b858fd304691f-refs/heads/master@{#432057}(32/64-bit)
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

Pre-condition:Save at least 3 password entries.  

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://md-settings/ 
(2)Click on 'Advanced' and click on 'Manage Passwords'
(3)Observe contents under 'Saved Passwords'.(Kindly refer the video)

Actual:Delay is seen while loading contents of 'Saved Passwords'

Expected:contents of 'Saved Passwords' should be displayed properly.

This is a Regression issue broken in M-56,will soon update other info.

Good build:56.0.2900.0
Bad build:56.0.2901.0


 
Actual result.mp4
453 KB View Download
Expected result.mp4
410 KB View Download

Comment 1 by hdodda@chromium.org, Nov 16 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:56.0.2900.0 (Revision:427219)
Bad build:56.0.2901.0 (Revision:427541)

You are probably looking for a change made after 427425 (known good), but no later than 427426 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0..6d67024bbbca61ddad11c5c242e30953af582637

From the CL above, assigning the issue to the concern owner 

@hcarmona - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2448653002

Thanks!
Tested the issue on Latest Canary# 57.0.2926.0 on Windows, Mac and Linux and is still reproducible.
@hcarmona - Could you please look into the issue and update.
Thanks in Advance.
Cc: rbasuvula@chromium.org
Just for update, Still able to reproduce the issue on Mac 10.11.6 using latest chrome version 57.0.2935.0.

hcarmona@ Could you please look into this issue.

Thanks!
Just for update, Still able to reproduce the issue on Mac 10.12.2 using latest chrome version 57.0.2956.0.

hcarmona@ Could you please look into this issue.

Thanks!
Just for update, Still able to reproduce the issue on Mac 10.12.2 and Win-10 using latest chrome version 57.0.2970.0.

hcarmona@ - Friendly Ping...!!

Could you please have a look into this issue.

Thanks...!!
Status: Started (was: Assigned)
Update on this issue:

Looks like the loading delay is happening only during the first navigation to the sub page when clicking the link.

This might be related to the sub page animation because navigating directly to chrome://md-settings/passwords does not have a delayed load.

However, chrome://md-settings/searchEngines (similar code) doesn't have the same load delay. I'm currently investigating this.
Blocking: 671375
Labels: Hotlist-MD-Settings-PasswordsForms
Just for update, Still able to reproduce the issue on Mac 10.12.2 using latest chrome version 58.0.2990.0.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7320f5e364e6c02b2d044612e4e488d70bb1e24f

commit 7320f5e364e6c02b2d044612e4e488d70bb1e24f
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Feb 16 21:07:02 2017

Load Passwords and Autofill in the corresponding sub page.

Moving the load into the sub page fixes the delay that is seen when
navigating into the passwords sub page. This has the added advantage
that items are not loaded at the top page.

BUG= 665748 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627123002
Cr-Commit-Position: refs/heads/master@{#451096}

[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7320f5e364e6c02b2d044612e4e488d70bb1e24f

commit 7320f5e364e6c02b2d044612e4e488d70bb1e24f
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Feb 16 21:07:02 2017

Load Passwords and Autofill in the corresponding sub page.

Moving the load into the sub page fixes the delay that is seen when
navigating into the passwords sub page. This has the added advantage
that items are not loaded at the top page.

BUG= 665748 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627123002
Cr-Commit-Position: refs/heads/master@{#451096}

[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/7320f5e364e6c02b2d044612e4e488d70bb1e24f/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Status: Fixed (was: Started)

Sign in to add a comment