New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665730 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

On startup we may show incomplete downloads list

Project Member Reported by vitaliii@chromium.org, Nov 16 2016 
Version: ToT

Currently on startup we notify UI about new suggestions on every |OnDownloadCreated| and when the offline page model is loaded. Marc suggested that we may end up in an incomplete state, e.g. if the NTP is created after a few |OnDownloadCreated| notifications, but before the offline page model was loaded. We cannot wait for Download Manager to load (issue 665727), but we can for offline pages model. The assumption is that after setting section status to AVAILABLE_LOADING NTP will wait for the first OnNewSuggestions call.

My main concert - what if it takes long time for offline page model to load? Also I have never saw the spinner on the NTP, so I would like to test this.

Comment 1 by vitaliii@chromium.org, Nov 16 2016 

Also the behavior may differ dramatically on a slower device (which is our target), so I would like to be extra cautious about this.

Comment 2 by vitaliii@chromium.org, Feb 1 2017

Status: WontFix (was: Available)
This is obsolete after issue 672758 has been resolved in https://codereview.chromium.org/2629603002. Now we wait for the download manager to load and then fetch all downloads including offline pages, so we won't show incomplete downloads list.
►

Sign in to add a comment