New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

OOPIF-<webview> Add option to about:flags

Project Member Reported by aval...@chromium.org, Nov 16 2016

Issue description

Allow setting the GuestViewCrossProcessFrames feature on the about:flags page.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89c538f4b15cb612c90605910bf2005142e46436

commit 89c538f4b15cb612c90605910bf2005142e46436
Author: avallee <avallee@chromium.org>
Date: Thu Nov 17 20:09:47 2016

Fix insufficient escaping of <webview>

<webview> needs to be &amp;lt;webview> such that the xml parses it as
&lt;webview> which will be concatenated into the about:flags html source.

BUG= 665722 

Review-Url: https://codereview.chromium.org/2506253003
Cr-Commit-Position: refs/heads/master@{#432939}

[modify] https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436/chrome/app/generated_resources.grd

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/318d45591423c20b531c131bf3b45052ab5afde7

commit 318d45591423c20b531c131bf3b45052ab5afde7
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed Nov 21 16:22:22 2018

Remove cross-process-guests from about:flags

cross-process-guests sets the value for the
GuestViewCrossProcessFrames feature. The feature itself has been
enabled by default since M63 (see issue 655753), however we've been
keeping it around for testing purposes.

It's no longer useful to have this exposed via about:flags, so we'll
remove it there, but keep the feature so we can still test with
--disable-features=GuestViewCrossProcessFrames

Bug: 533069,  665722 
Change-Id: I1dcb84e0facf288059bc1cad555108f543847ae1
Reviewed-on: https://chromium-review.googlesource.com/c/1340916
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610098}
[modify] https://crrev.com/318d45591423c20b531c131bf3b45052ab5afde7/chrome/browser/about_flags.cc
[modify] https://crrev.com/318d45591423c20b531c131bf3b45052ab5afde7/chrome/browser/flag-metadata.json
[modify] https://crrev.com/318d45591423c20b531c131bf3b45052ab5afde7/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/318d45591423c20b531c131bf3b45052ab5afde7/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/318d45591423c20b531c131bf3b45052ab5afde7/content/public/common/content_features.cc
[modify] https://crrev.com/318d45591423c20b531c131bf3b45052ab5afde7/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment